From: Thomas Koenig <tkoenig@netcologne.de>
To: Andre Vehreschild <vehre@gmx.de>,
GCC-Patches-ML <gcc-patches@gcc.gnu.org>,
GCC-Fortran-ML <fortran@gcc.gnu.org>
Subject: Re: [Fortran, Patch, PR72698, v1] [5/6/7 Regression] ICE in lhd_incomplete_type_error, at langhooks.c:205
Date: Mon, 08 Aug 2016 06:42:00 -0000 [thread overview]
Message-ID: <b434cfb0-2fc7-4e52-14d0-5032c2ce870c@netcologne.de> (raw)
In-Reply-To: <20160807135234.7dd4c7fc@vepi2>
Am 07.08.2016 um 13:52 schrieb Andre Vehreschild:
Hi Andre,
> attached patch fixes the ICE caused by a zero-sized string. Assigning
> that string to a temporary variable obviously did not work out. The
> patch fixes this by checking for zero-sized strings in SOURCE= and not
> producing the code to assign "nothing" to the temporary
> variable and later to the allocated memory. The version for gcc-5 had
> to be adapted slightly, because the version of the ALLOCATE()
> implementation is way behind.
>
> Bootstrapped and regtested on x86_64-linux-gnu/F23. Ok for trunk, gcc-6
> and gcc-5?
Looks good.
With the test case, you might consider changing that into a runtime
test to make sure that the correct result is obtained.
So, OK with that change.
Regards
Thomas
next prev parent reply other threads:[~2016-08-08 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 11:52 Andre Vehreschild
2016-08-07 13:40 ` Andre Vehreschild
2016-08-08 6:42 ` Thomas Koenig [this message]
2016-08-08 9:50 ` Andre Vehreschild
2016-08-11 7:58 ` Andre Vehreschild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b434cfb0-2fc7-4e52-14d0-5032c2ce870c@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=vehre@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).