From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Kwok_Yeung@mentor.com>
Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153])
 by sourceware.org (Postfix) with ESMTPS id 9C85E3894C2A
 for <gcc-patches@gcc.gnu.org>; Tue, 13 Oct 2020 20:26:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9C85E3894C2A
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=codesourcery.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=Kwok_Yeung@mentor.com
IronPort-SDR: +K8fGGs6taESmFFEQYXt39gq54aZhnRU3gErf9AdLM4BSu+VXP9g4OvaztrKn8Zeyl7MsbjDBM
 oBlRvkm0EaeyBgELAXZrzzUtYbZmpveYGPKvKPUKXXseCLxxQYNviw7XqBzzToOD24Foi3Uq6h
 jPysjY+AWgku+qRO9gz8fv6Q5ng1sg9umK9+vwWri211uQQJT9cExhGciGl2fXOYvmg1bwQAf1
 TPagItj6lkFBCtMOn9LUY8XeeFmwL3IfsRdgD4peg45p1bWweLBDS2PFs++fkdUv7L6Ikn9NjZ
 HME=
X-IronPort-AV: E=Sophos;i="5.77,371,1596528000"; d="scan'208";a="56157173"
Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167])
 by esa1.mentor.iphmx.com with ESMTP; 13 Oct 2020 12:26:31 -0800
IronPort-SDR: PyM3i8vX10IWagadeYhE/tlOUvr6LLSJrDphmdsa9w0uB3F1Zy7QjUeSBMT2SDty3rlhwMGakv
 nqtBDppDCh7kS2wF84LtFeZv2T5C1uIoWx3+emLdlKBnwuZqeoI3dfWmxQCqLj7dD4CKf8SLV7
 W9+Kx/M1tSWmxNNEa71hG4JXpnZ3Ut5oQVo2FjQoUZkYomQhMsdRPpI/nz723zQ8YmjmzsmvqN
 WTTjvytta1Mwc85RyN2YUJvvu3eibIT2fJtQ9wiKLHjAKDSGty2UOQ20fX1rZI5pFefJr6GR++
 9KM=
Subject: Re: [PATCH] openmp: Add support for omp_get_supported_active_levels
To: Jakub Jelinek <jakub@redhat.com>
CC: GCC Patches <gcc-patches@gcc.gnu.org>, Tobias Burnus
 <tobias@codesourcery.com>
References: <95c1a0d9-2cc5-4f82-dc44-13efa38df115@codesourcery.com>
 <20201013183650.GF2176@tucnak>
From: Kwok Cheung Yeung <kcy@codesourcery.com>
Message-ID: <b442812b-b502-2692-a7ba-d696611b7afb@codesourcery.com>
Date: Tue, 13 Oct 2020 21:26:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <20201013183650.GF2176@tucnak>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To
 svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,
 HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Oct 2020 20:26:34 -0000

Now committed to trunk with the suggested fixes. Thanks for the quick review.

Kwok

On 13/10/2020 7:36 pm, Jakub Jelinek wrote:

> I'd suggest to
> #define gomp_supported_active_levels INT_MAX
> in libgomp.h and leave out the const variable.  Another possibility is an
> enumerator, but we don't include limits.h in libgomp.h.
> 
> OMP_5.0 symbol version has been shipped already in GCC 9.  So we should
> never add any further symbols to it.
> Thus it needs to be added to OMP_5.0.1 symbol version instead (which is new
> in GCC 11).
> 
> Otherwise LGTM.