From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id E30583858D32 for ; Thu, 7 Jul 2022 09:02:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E30583858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.92,252,1650960000"; d="scan'208";a="78426363" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 07 Jul 2022 01:02:53 -0800 IronPort-SDR: 8GAjvDcnaxNR9AlGcCr9vbj6J57q8CS1ueA6Nu1Q6yYcbGoAycDA3jWbpsF3fpH0TQdNHg3rpX q+3UPXNq+6w1ganK2BJZrx53CWpzJuapsZFwi4LhQZLrXgE4KpZYpVPyFU2qF3VZjamq6/m5CT Z276gCCk6VI9jnEyHrgJ4thvMpEEv0O+Yboilvpu9fmJCw1pT5/VfTYtEAJEmfoRpFATcfqvAY 5v9HeQH7SPXXzPoO2mVcYpJCCOx1KwiRMin9C1enYRHid5cKUr231MJp++VnLYaNuMmIvBPZbe D7Y= Message-ID: Date: Thu, 7 Jul 2022 11:02:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Adjust 'libgomp.c-c++-common/requires-3.c' (was: [Patch][v4] OpenMP: Move omp requires checks to libgomp) Content-Language: en-US To: Thomas Schwinge , CC: Jakub Jelinek References: <07fec82a-41cf-fdc5-6307-c068dd95ef1a@mentor.com> <7f9c91c1-a479-f94f-ac14-1d6827ce671b@codesourcery.com> <5576fa00-0ddd-8046-17c1-d1cea82bdcf5@codesourcery.com> <87o7y148te.fsf@euler.schwinge.homeip.net> From: Tobias Burnus In-Reply-To: <87o7y148te.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-06.mgc.mentorg.com (139.181.222.6) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 09:03:00 -0000 Hi Thomas, hello all, On 07.07.22 10:37, Thomas Schwinge wrote: > In preparation for other changes: > > On 2022-06-29T16:33:02+0200, Tobias Burnus wrot= e: >> +++ b/libgomp/testsuite/libgomp.c-c++-common/requires-3.c >> @@ -0,0 +1,24 @@ >> +/* { dg-do link { target offloading_enabled } } */ > Not expected to see 'offloading_enabled' here... > >> +/* { dg-additional-sources requires-3-aux.c } */ >> + >> +/* Check diagnostic by device-compiler's lto1. > ..., because of this note ^. ... > Subject: [PATCH] Adjust 'libgomp.c-c++-common/requires-3.c' ... > libgomp/ > * testsuite/libgomp.c-c++-common/requires-3.c: Adjust. ... > index 4b07ffdd09b..7091f400ef0 100644 > --- a/libgomp/testsuite/libgomp.c-c++-common/requires-3.c > +++ b/libgomp/testsuite/libgomp.c-c++-common/requires-3.c > @@ -1,4 +1,4 @@ > -/* { dg-do link { target offloading_enabled } } */ > +/* { dg-do link { target { offload_target_nvptx || offload_target_amdgcn= } } } */ LGTM. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955