public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Vladimir Makarov <vmakarov@redhat.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH] Fix PR80754
Date: Wed, 24 May 2017 15:43:00 -0000	[thread overview]
Message-ID: <b48ea9c6-09e1-3b48-afd9-4a93c6eb9d26@redhat.com> (raw)
In-Reply-To: <AM5PR0802MB2610B05C3B97A047AE03CA5D83E70@AM5PR0802MB2610.eurprd08.prod.outlook.com>



On 05/17/2017 07:32 AM, Wilco Dijkstra wrote:
> When lra-remat rematerializes an instruction with a clobber, it checks
> that the clobber does not kill live registers.  However it fails to check
> that the clobber also doesn't overlap with the destination register of the
> final rematerialized instruction.  As a result it is possible to generate
> illegal instructions with the same hard register as the destination and a
> clobber.  Fix this by also checking for overlaps with the destination
> register.
>
> Bootstrap OK on arm-linux-gnueabihf for ARM and Thumb-2, OK for commit?
>
>
Wilco, thank you for working on the PR.

The patch looks OK for me.  You can commit it into the trunk and gcc7 
branch.

      reply	other threads:[~2017-05-24 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 11:39 Wilco Dijkstra
2017-05-24 15:43 ` Vladimir Makarov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b48ea9c6-09e1-3b48-afd9-4a93c6eb9d26@redhat.com \
    --to=vmakarov@redhat.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).