From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17227 invoked by alias); 24 May 2017 15:20:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17207 invoked by uid 89); 24 May 2017 15:20:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 May 2017 15:20:37 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E517635C5; Wed, 24 May 2017 15:20:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1E517635C5 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vmakarov@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1E517635C5 Received: from [10.10.120.161] (ovpn-120-161.rdu2.redhat.com [10.10.120.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E6809172E; Wed, 24 May 2017 15:20:39 +0000 (UTC) Subject: Re: [PATCH] Fix PR80754 To: Wilco Dijkstra , GCC Patches References: Cc: nd From: Vladimir Makarov Message-ID: Date: Wed, 24 May 2017 15:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg01884.txt.bz2 On 05/17/2017 07:32 AM, Wilco Dijkstra wrote: > When lra-remat rematerializes an instruction with a clobber, it checks > that the clobber does not kill live registers. However it fails to check > that the clobber also doesn't overlap with the destination register of the > final rematerialized instruction. As a result it is possible to generate > illegal instructions with the same hard register as the destination and a > clobber. Fix this by also checking for overlaps with the destination > register. > > Bootstrap OK on arm-linux-gnueabihf for ARM and Thumb-2, OK for commit? > > Wilco, thank you for working on the PR. The patch looks OK for me. You can commit it into the trunk and gcc7 branch.