From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 9EFCD3858407 for ; Wed, 22 Nov 2023 09:41:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9EFCD3858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9EFCD3858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700646080; cv=none; b=fdSnlMzFfY0kHAJMhq2Ho66VELbjgO25fKHa1OinB0DlDqJL91shedI4mD4npg44gjzds6MzYlm5YRwTe/9czOhNGiGlraItHz5Cgqg2woI+86q1SCL4VZAC4Bp0iQsFhGO+but7FoG/6p/zwKgKv7/f28oLwsa+2JiispIV7wM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700646080; c=relaxed/simple; bh=VJNGaP/srAk3rsEa8HIKRECqoII/svAnR9BeIYqYZvk=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=eJi8sMC6L3KyjokIhkHDY1nh4skgTM7fg5UNwFtVDUndV11MR2Islm5LkPsvdetlAZjMd8EtVImEFKtg+5guNAeIdLCyF6glGgRtWfg9f8749ErC+3mTEYcji9G8Rtya1NG7c3kbbJNoM+tb08EdYN3gLKj4yfJsYFDzr0PwTLw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2BF801595; Wed, 22 Nov 2023 01:42:06 -0800 (PST) Received: from [10.57.42.111] (unknown [10.57.42.111]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 379453F73F; Wed, 22 Nov 2023 01:41:18 -0800 (PST) Message-ID: Date: Wed, 22 Nov 2023 09:41:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM/testsuite: Use non-capturing parentheses with pr53447-5.c Content-Language: en-GB To: "Maciej W. Rozycki" , "gcc-patches@gcc.gnu.org" Cc: "nickc@redhat.com" , Richard Earnshaw , Ramana Radhakrishnan , Kyrylo Tkachov , Jeff Law References: From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3487.7 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/11/2023 01:40, Maciej W. Rozycki wrote: > Use non-capturing parentheses for the subexpressions used with > `scan-assembler-times', to avoid a quirk with double-counting. > >         gcc/testsuite/ >         * gcc.target/arm/pr53447-5.c: Use non-capturing parentheses with >         `scan-assembler-times'. > --- > Hi, > >  The `scan-assembler-times' quirk is being fixed with > >, but > we don't need capturing parentheses here, typically used for back > references, so let's just avoid the quirk altogether and make our matching > here work either way.  Cf. commit 88c888f11379 ("pr53447-5.c: Fix test > expectations for neon-fpu."). > >  Verified by proof-reading, with a reference to the commit quoted above. > OK to apply? > >   Maciej > --- >  gcc/testsuite/gcc.target/arm/pr53447-5.c |    8 +++----- >  1 file changed, 3 insertions(+), 5 deletions(-) > > gcc-arm-test-pr53447-5-non-capturing.diff > Index: gcc/gcc/testsuite/gcc.target/arm/pr53447-5.c > =================================================================== > --- gcc.orig/gcc/testsuite/gcc.target/arm/pr53447-5.c > +++ gcc/gcc/testsuite/gcc.target/arm/pr53447-5.c > @@ -15,8 +15,6 @@ void foo(long long* p) >    p[9] -= p[10]; >  } > > -/* We accept neon instructions vldr.64 and vstr.64 as well. > -   Note: DejaGnu counts patterns with alternatives twice, > -   so actually there are only 10 loads and 9 stores.  */ > -/* { dg-final { scan-assembler-times "(ldrd|vldr\\.64)" 20 } } */ > -/* { dg-final { scan-assembler-times "(strd|vstr\\.64)" 18 } } */ > +/* We accept neon instructions vldr.64 and vstr.64 as well.  */ > +/* { dg-final { scan-assembler-times "(?:ldrd|vldr\\.64)" 10 } } */ > +/* { dg-final { scan-assembler-times "(?:strd|vstr\\.64)" 9 } } */ OK. Thanks. R.