public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: "Richard Biener" <richard.guenther@gmail.com>,
	"Martin Liška" <mliska@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] Handle PHI nodes w/o a argument (PR ipa/80205).
Date: Mon, 27 Mar 2017 15:30:00 -0000	[thread overview]
Message-ID: <b4a44d5d-b362-7d5b-5c62-5ed8a96be2e6@redhat.com> (raw)
In-Reply-To: <CAFiYyc1wRxXfDjtKa97wtgTdPUQF9B1v3EWoLQWAAFOBFWfwCA@mail.gmail.com>

On 03/27/2017 08:27 AM, Richard Biener wrote:
> On Mon, Mar 27, 2017 at 4:14 PM, Richard Biener
> <richard.guenther@gmail.com> wrote:
>> On Mon, Mar 27, 2017 at 2:47 PM, Martin Liška <mliska@suse.cz> wrote:
>>> Hello.
>>>
>>> As described in the PR, we can create a PHI node in einline that has no argument.
>>> That can cause ICE in devirtualization and should be thus handled.
>>>
>>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>>
>>> Ready to be installed?
>>
>> We shouldn't ever have a PHI w/o argument.
>
> ;;   basic block 14, loop depth 0
> ;;    pred:
>   # SR.2_19 = PHI <>
> <L4> [0.00%]:
>   a::~a (&g);
>   resx 12
> ;;    succ:       17
>
> the CFG has not been cleaned up here (this block is unreachable).
>
> Hmm, I see we are called from fold_stmt.  I suppose we process
> statements_to_fold before removing unreachable blocks to not
> walk over dead stmts...  chicken-and-egg...
>
> Still not creating that PHI should be possible.
Can't speak for this specific example, but could it be the case that the 
PHI exists with arguments, then becomes unreachable resulting in a PHI 
with no arguments?

jeff

  reply	other threads:[~2017-03-27 15:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 12:51 Martin Liška
2017-03-27 14:25 ` Richard Biener
2017-03-27 14:27   ` Jeff Law
2017-03-27 14:28   ` Richard Biener
2017-03-27 15:30     ` Jeff Law [this message]
2017-03-28  7:52     ` Martin Liška
2017-03-28  8:23       ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4a44d5d-b362-7d5b-5c62-5ed8a96be2e6@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=mliska@suse.cz \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).