From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id 21ECD385734F for ; Tue, 11 Oct 2022 13:58:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21ECD385734F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=woven-planet.global Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=woven-planet.global Received: by mail-lj1-x22e.google.com with SMTP id j26so1471570ljg.13 for ; Tue, 11 Oct 2022 06:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=woven-planet.global; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cztkPYJW8hwFxrEZTaIfm+olNiPsPv3Xn1sVgC3RLDs=; b=YmunIE3wwsuyqtr2oobYahcFDs3AiBiP7lYi/vmYrxNpIlmjjTR/og8+87lEWwnfox XDcF+cDY6iHWPEPMIF7e98uA5bMJiS4uSxpJJPknvme+ce4FRIEBAdf+mzodjmyQpSwi 1o4+7z0S3f4Sw+e98RmdIvcMwc11IrikVEvHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cztkPYJW8hwFxrEZTaIfm+olNiPsPv3Xn1sVgC3RLDs=; b=1zbU+J0KJDa74BHo93miY5n0S5jyDoLDRTV+c0MXd1jPGbic8Cmo3YutxJM0nLxMgk /G8WzJaGfyZ9sXB7KjO2WkjkTEDDc68bneGbRczta/njfNEY7wKaQjtqJX/j0aai7jOa BG0IFn6YJgCaH1c9Z3rxQhFoiS43iTHIMIO0+xJKJk4RMwc2tV77YhKnXwSXeQymNWWC MiEAcBTO0PKV4rkb9DZLdrP/u6ysDV2Q3QkKnpnEh8K2syG77Gv4jzar2M1ZJ9IAoh21 MMAAicSsfkFA25d8zxOSe7XAurjxdgmncXlkvgVKreaoFHLOKxs1hPP6PZSX/yleRngD 6djw== X-Gm-Message-State: ACrzQf04nQlNblz+nxeT5eI4GxSHXVok0SyLrIwaNWNsJsXENj0lVHnB 4fHY992rszYSWCLm1xQqA0BpbQ== X-Google-Smtp-Source: AMsMyM4wYTbF8C7UtoZbLhhjmnUh5O6rToGkQMkP7CEt0cZDyNonUhz+2loDj6bZU6ew6qWB3Sbp+g== X-Received: by 2002:a2e:8719:0:b0:26e:b9:31a9 with SMTP id m25-20020a2e8719000000b0026e00b931a9mr9580985lji.111.1665496682432; Tue, 11 Oct 2022 06:58:02 -0700 (PDT) Received: from ?IPV6:2a02:2121:6ca:a542:1c10:1c18:418e:cd9d? ([2a02:2121:6ca:a542:1c10:1c18:418e:cd9d]) by smtp.gmail.com with ESMTPSA id 9-20020ac25f49000000b0049771081b10sm1871911lfz.31.2022.10.11.06.58.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 06:58:01 -0700 (PDT) Message-ID: Date: Tue, 11 Oct 2022 15:57:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 1/2] gcov: test switch/break line counts Content-Language: en-US To: Michael Matz Cc: gcc-patches@gcc.gnu.org References: <20221011124303.99673-1-jorgen.kvalsvik@woven-planet.global> From: =?UTF-8?Q?J=c3=b8rgen_Kvalsvik?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,TXREP,T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/10/2022 15:55, Michael Matz wrote: > Hello, > > On Tue, 11 Oct 2022, Jørgen Kvalsvik via Gcc-patches wrote: > >> The coverage support will under some conditions decide to split edges to >> accurately report coverage. By running the test suite with/without this >> edge splitting a small diff shows up, addressed by this patch, which >> should catch future regressions. >> >> Removing the edge splitting: >> >> $ diff --git a/gcc/profile.cc b/gcc/profile.cc >> --- a/gcc/profile.cc >> +++ b/gcc/profile.cc >> @@ -1244,19 +1244,7 @@ branch_prob (bool thunk) >> Don't do that when the locuses match, so >> if (blah) goto something; >> is not computed twice. */ >> - if (last >> - && gimple_has_location (last) >> - && !RESERVED_LOCATION_P (e->goto_locus) >> - && !single_succ_p (bb) >> - && (LOCATION_FILE (e->goto_locus) >> - != LOCATION_FILE (gimple_location (last)) >> - || (LOCATION_LINE (e->goto_locus) >> - != LOCATION_LINE (gimple_location (last))))) >> - { >> - basic_block new_bb = split_edge (e); >> - edge ne = single_succ_edge (new_bb); >> - ne->goto_locus = e->goto_locus; >> - } >> + > > Assuming this is correct (I really can't say) then the comment needs > adjustments. It specifically talks about this very code you remove. > > > Ciao, > Michael. Michael, I apologise for the confusion. The diff there is not a part of the change itself (note the indentation) but rather a way to reproduce, or at least understand, the type of change that would trigger the new test error. If it is too confusing I can re-write the commit message. Thanks, Jørgen