Re: [PATCH v1] RISC-V: Refactor RVV class by frm_op_type template arg

[Jeff Law <jeffreyalaw@gmail.com>]

On 8/17/23 20:53, Pan Li via Gcc-patches wrote:
> From: Pan Li <pan2.li@intel.com>
> 
> As suggested by kito, we will add new frm_opt_type template arg
> to the op class, to avoid the duplicated function expand.
> 
> Signed-off-by: Pan Li <pan2.li@intel.com>
> 
> gcc/ChangeLog:
> 
> 	* config/riscv/riscv-vector-builtins-bases.cc
> 	(class binop_frm): Removed.
> 	(class reverse_binop_frm): Ditto.
> 	(class widen_binop_frm): Ditto.
> 	(class vfmacc_frm): Ditto.
> 	(class vfnmacc_frm): Ditto.
> 	(class vfmsac_frm): Ditto.
> 	(class vfnmsac_frm): Ditto.
> 	(class vfmadd_frm): Ditto.
> 	(class vfnmadd_frm): Ditto.
> 	(class vfmsub_frm): Ditto.
> 	(class vfnmsub_frm): Ditto.
> 	(class vfwmacc_frm): Ditto.
> 	(class vfwnmacc_frm): Ditto.
> 	(class vfwmsac_frm): Ditto.
> 	(class vfwnmsac_frm): Ditto.
> 	(class unop_frm): Ditto.
> 	(class vfrec7_frm): Ditto.
> 	(class binop): Add frm_op_type template arg.
> 	(class unop): Ditto.
> 	(class widen_binop): Ditto.
> 	(class widen_binop_fp): Ditto.
> 	(class reverse_binop): Ditto.
> 	(class vfmacc): Ditto.
> 	(class vfnmsac): Ditto.
> 	(class vfmadd): Ditto.
> 	(class vfnmsub): Ditto.
> 	(class vfnmacc): Ditto.
> 	(class vfmsac): Ditto.
> 	(class vfnmadd): Ditto.
> 	(class vfmsub): Ditto.
> 	(class vfwmacc): Ditto.
> 	(class vfwnmacc): Ditto.
> 	(class vfwmsac): Ditto.
> 	(class vfwnmsac): Ditto.
> 	(class float_misc): Ditto.
So in the expand method, you added a case for OP_TYPE_vx.  I assume that 
was intentional -- but it's not mentioned anywhere in the ChangeLog.  So 
please update the ChangeLog if it was intentional or remove the change 
if it wasn't intentional.  Pre-approved with whichever change is 
appropriate.

Thanks,
Jeff