From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B6C8C385BF92 for ; Wed, 1 Apr 2020 17:49:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B6C8C385BF92 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 031HYVbx007159; Wed, 1 Apr 2020 13:48:57 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 301yfh444w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Apr 2020 13:48:57 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 031Hi32n008013; Wed, 1 Apr 2020 17:48:56 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03dal.us.ibm.com with ESMTP id 301x77ucc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Apr 2020 17:48:56 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 031Hmtms51970514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 1 Apr 2020 17:48:55 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED7BE6A04D; Wed, 1 Apr 2020 17:48:54 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 419E96A051; Wed, 1 Apr 2020 17:48:54 +0000 (GMT) Received: from [9.160.53.188] (unknown [9.160.53.188]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 1 Apr 2020 17:48:54 +0000 (GMT) Subject: Re: [PATCH] lower-subreg: PR94123, SVN r273240, causes gcc.target/powerpc/pr87507.c to fail To: Segher Boessenkool , richard.sandiford@arm.com References: <20ee8944-f0bf-cec1-e3d1-5dd5e9c6a4ef@linux.ibm.com> Cc: gcc-patches , "ian@airs.com" From: Peter Bergner Message-ID: Date: Wed, 1 Apr 2020 12:48:53 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-01_03:2020-03-31, 2020-04-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxscore=0 phishscore=0 clxscore=1015 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004010146 X-Spam-Status: No, score=-18.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 17:49:16 -0000 On 3/30/20 3:50 AM, Richard Sandiford wrote: > Peter Bergner via Gcc-patches writes: >> * lower-subreg.c (pass_lower_subreg3::gate): Remove test for >> flag_split_wide_types_early. >> >> diff --git a/gcc/lower-subreg.c b/gcc/lower-subreg.c >> index 4c8bc835f93..807ad398b64 100644 >> --- a/gcc/lower-subreg.c >> +++ b/gcc/lower-subreg.c >> @@ -1844,8 +1844,7 @@ public: >> {} >> >> /* opt_pass methods: */ >> - virtual bool gate (function *) { return flag_split_wide_types >> - && !flag_split_wide_types_early; } >> + virtual bool gate (function *) { return flag_split_wide_types != 0; } >> virtual unsigned int execute (function *) >> { >> decompose_multiword_subregs (true); > > Looks good to me with the s/ != 0// that Segher mentioned. > > With this change, the only remaining function of -fsplit-wide-types-early > is to act as a double lock on one pass. IMO it'd make more sense to remove > that double lock and make -fsplit-wide-types-early and -fsplit-wide-types > act as independent options, a bit like -fschedule-insns{,2}. Have we come to consensus on whether to split the options or not? I think Segher is against it given we actually have 3 passes of lower-subreg and -fsplit-wide-types would control the 1st and 3rd passes and -fsplit-wide-types-early would control the second. That does seem strange to me too. Peter