public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Kito Cheng <kito.cheng@sifive.com>,
	gcc-patches@gcc.gnu.org, kito.cheng@gmail.com,
	palmer@dabbelt.com
Subject: Re: [PATCH] RISC-V: Emit .note.GNU-stack for non-linux target as well
Date: Tue, 5 Sep 2023 01:17:10 -0600	[thread overview]
Message-ID: <b5975383-c4dd-4456-92e5-fddcae6d2589@gmail.com> (raw)
In-Reply-To: <20230831090547.71737-1-kito.cheng@sifive.com>



On 8/31/23 03:05, Kito Cheng wrote:
> We only emit that on linux target before, that not problem before,
> however Qemu has fix a bug to make qemu user mode honor PT_GNU_STACK[1],
> that will cause problem when we test baremetal with qemu.
> 
> So the straightforward is enable that as well for non-linux toolchian,
> the price is that will increase few bytes for each binary.
> 
> [1] https://github.com/qemu/qemu/commit/872f3d046f2381e3f416519e82df96bd60818311
> 
> gcc/ChangeLog:
> 
> 	* config/riscv/linux.h (TARGET_ASM_FILE_END): Move ...
> 	* config/riscv/riscv.cc (TARGET_ASM_FILE_END): to here.
OK.
jeff

  reply	other threads:[~2023-09-05  7:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31  9:05 Kito Cheng
2023-09-05  7:17 ` Jeff Law [this message]
2023-09-05 12:14   ` Kito Cheng
2023-09-05 20:53     ` Fangrui Song
2023-09-06  2:57       ` Kito Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5975383-c4dd-4456-92e5-fddcae6d2589@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kito.cheng@gmail.com \
    --cc=kito.cheng@sifive.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).