From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C68923858D1E for ; Mon, 15 Aug 2022 15:48:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C68923858D1E Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-393-fVZEZ9MrPbyr4RuA3b6Uvw-1; Mon, 15 Aug 2022 11:48:39 -0400 X-MC-Unique: fVZEZ9MrPbyr4RuA3b6Uvw-1 Received: by mail-qk1-f200.google.com with SMTP id w17-20020a05620a425100b006b97978c693so7240131qko.19 for ; Mon, 15 Aug 2022 08:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc; bh=XoZowoRFiz7gkFECdBYzeBLXAsEKhvaXJsCd0HZqWk0=; b=sEaj/ZJeoKjjGKl5ygQOkI5t7OpXCOX2mZdREtLCvlwIQgXXE8n9i5+S8xgW8aPp6E /2FOOoPNb07UQYjR1d1ZySACeMQSu7+hpPU4buCrEx10nEEuwAyXCTfSrCgwx7+d3pUi 8t27gm6uBNYqt7wgAOk2bCEd91Z5t/i0GDinUpbjkhK/PA/Th832d0VhJ1ZsLAGMVdmx 9DNBTmee9wAtlqIaWiHkhWhXslD5Sa3eXYeUX9scmsvZWQ5Qu6GnWfJojGVEUKxfykwB SFYqF7nsoPGb16ZBD5IifVTXQrGM7ttnpe8GZusynNAMaXHhQ+S1r/lmxyjuLfzhUNFi YAsw== X-Gm-Message-State: ACgBeo1licbbO+4abz+OZS4s1evFVrQJiH5iQaV/ZpJZAlTt0fW1438O 1cpL8E/oQC7MqAR45OrrTl4cZBpOQMIzk7+xCQLyW+wO+Y9pOXlyT7adVZsc4Uowxb2Vp2u2VMk hppTHqSEzMm77i0QAoA== X-Received: by 2002:ad4:5ecc:0:b0:474:8880:7a3e with SMTP id jm12-20020ad45ecc000000b0047488807a3emr14073581qvb.5.1660578519049; Mon, 15 Aug 2022 08:48:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7vO06DeiMWs7jE7a4v+NGHM664mjCQniTRYEF6oqBayh2aCSPw3o448gYUmpYcZEP3RzuepQ== X-Received: by 2002:ad4:5ecc:0:b0:474:8880:7a3e with SMTP id jm12-20020ad45ecc000000b0047488807a3emr14073562qvb.5.1660578518750; Mon, 15 Aug 2022 08:48:38 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id l3-20020a05620a28c300b006bb2661f3fasm3869706qkp.133.2022.08.15.08.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 08:48:34 -0700 (PDT) Message-ID: Subject: Re: [PATCH] analyzer: fix for ICE in sm-fd.cc [PR106551] From: David Malcolm To: mirimnan017@gmail.com, gcc-patches@gcc.gnu.org Cc: Immad Mir Date: Mon, 15 Aug 2022 11:48:31 -0400 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 15:48:43 -0000 On Mon, 2022-08-15 at 14:02 +0530, Immad Mir wrote: > This patch fixes the ICE caused by valid_to_unchecked_state > in sm-fd.cc by exiting early if first argument of any "dup" > functions is invalid. >=20 > gcc/analyzer/ChangeLog: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0PR analyzer/106551 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* sm-fd.cc (check_for_dup= ): exit early if first > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0argument is invalid for a= ll dup functions. >=20 > gcc/testsuite/ChangeLog: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0PR analyzer/106551 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* gcc.dg/analyzer/fd-dup-= 1.c: New testcase. >=20 > Signed-off-by: Immad Mir Thanks; looks good to me. Dave