From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20881 invoked by alias); 1 Nov 2019 02:21:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20872 invoked by uid 89); 1 Nov 2019 02:21:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,MIME_CHARSET_FARAWAY,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Nov 2019 02:21:36 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA12IcCM064704 for ; Thu, 31 Oct 2019 22:21:33 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2w09nvbh6w-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 31 Oct 2019 22:21:33 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Nov 2019 02:21:32 -0000 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 1 Nov 2019 02:21:28 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA12LRd447513968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Nov 2019 02:21:27 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1CBFBA405F; Fri, 1 Nov 2019 02:21:27 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CA796A4054; Fri, 1 Nov 2019 02:21:25 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.147.184]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 1 Nov 2019 02:21:25 +0000 (GMT) Subject: Re: [PATCH 3/3 V2][rs6000] vector conversion RTL pattern update for diff unit size To: Segher Boessenkool Cc: GCC Patches , Bill Schmidt References: <172addbc-3aae-084b-cce4-b9c8a194821d@linux.ibm.com> <22fd6de1-dc31-a977-a803-0a2cb3f11444@linux.ibm.com> <20191030184929.GM28442@gate.crashing.org> <20191031184859.GX28442@gate.crashing.org> From: "Kewen.Lin" Date: Fri, 01 Nov 2019 02:21:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191031184859.GX28442@gate.crashing.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit x-cbid: 19110102-0008-0000-0000-00000329ACF7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110102-0009-0000-0000-00004A48FB2B Message-Id: X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00002.txt.bz2 Hi Segher, on 2019/11/1 ÉÏÎç2:49, Segher Boessenkool wrote: > Hi! > > On Thu, Oct 31, 2019 at 05:35:22PM +0800, Kewen.Lin wrote: >>>> +/* Half VMX/VSX vector (for select) */ >>>> +VECTOR_MODE (FLOAT, SF, 2); /* V2SF */ >>>> +VECTOR_MODE (INT, SI, 2); /* V2SI */ >>> >>> Or "for internal use", in general. What happens if a user tries to create >>> something of such a mode? I hope we don't ICE :-/ >> >> I did some testings, it failed (ICE) if we constructed one insn with these >> modes artificially. But I also checked the existing V8SF/V8SI/V4DF/... etc., >> they have same issues. It looks more like a new issue to avoid that. > > What does "artificially" mean? If you had to change the compiler for your > test, that doesn't count; otherwise, please file a PR. > Yes, I hacked the compiler to emit it directly. OK, it's fine then. :) >> * config/rs6000/vsx.md (UNSPEC_VSX_CVSPSXDS, UNSPEC_VSX_CVSPUXDS): Remove. > > (line too long) Will fix it. > > Okay for trunk. Thanks! > Thanks for your time! BR, Kewen