public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [committed] Fix return type on stack clash protection hook
Date: Tue, 10 Oct 2017 08:13:00 -0000	[thread overview]
Message-ID: <b5e2b4e4-ce95-ce1f-66cb-e8cefb238b9e@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Pointed out in IRC.   The intent as well as the docs and prototype had
the return type as a bool, but the default implementation used
HOST_WIDE_INT.  Opps.

This fixes the default implementation to match the intent, docs &
prototype.  Bootstrapped and regression tested.  Installing on the trunk
as obvious.

Jeff

[-- Attachment #2: P --]
[-- Type: text/plain, Size: 1105 bytes --]

commit fdc63db3b0343eaa3cdde6d5c143fbd80a851da6
Author: Jeff Law <law@torsion.usersys.redhat.com>
Date:   Mon Oct 9 17:29:58 2017 -0400

            * targhooks.c (default_stack_clash_protection_final_dynamic_probe): Fix
            return type to match prototype and documentation.

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 202dd89b957..30bbeb5ad82 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2017-10-09  Jeff Law  <law@redhat.com>
+
+	* targhooks.c (default_stack_clash_protection_final_dynamic_probe): Fix
+	return type to match prototype and documentation.
+
 2010-10-09  Segher Boessenkool  <segher@kernel.crashing.org>
 
 	* config/rs6000/rs6000.c (processor_costs): Move to ...
diff --git a/gcc/targhooks.c b/gcc/targhooks.c
index d56f53d35d8..8dbf8a14970 100644
--- a/gcc/targhooks.c
+++ b/gcc/targhooks.c
@@ -2235,7 +2235,7 @@ default_excess_precision (enum excess_precision_type ATTRIBUTE_UNUSED)
   return FLT_EVAL_METHOD_PROMOTE_TO_FLOAT;
 }
 
-HOST_WIDE_INT
+bool
 default_stack_clash_protection_final_dynamic_probe (rtx residual ATTRIBUTE_UNUSED)
 {
   return 0;

                 reply	other threads:[~2017-10-10  6:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5e2b4e4-ce95-ce1f-66cb-e8cefb238b9e@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).