From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 072D93858D33 for ; Mon, 13 Feb 2023 06:41:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 072D93858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x129.google.com with SMTP id s9so3673809ilt.1 for ; Sun, 12 Feb 2023 22:41:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Rp9YDIaPYta60mQ/BsrLSBix9CUGWyFm/2p9lkJW98=; b=bseQdL9OZSidEaYyyjT3XCOBlBsYIprlduBuY6zD4COlK9shXtWDEYBUbddYeh8FPj 5r/r+PryiT+J77rDcOed3LIdSQUOHaRs7OXsOmwUJMyNCDgK0zxG3x+9llRkui9qH520 5dSXQJpz3f8/AoQoQmRjIThpWwrQtBPUKnCNYMzJCbMAupz5CiVrI/mZEkX425/HkTmG 46Gz1VDAt/biTvbpAx1+okl/1WRIIKgKraxbOVbuT8pLDlzPFVIa3kBOBuULYMw81WQ0 M3OkP1ehrbYxMMgPnc86T3PeLpdufafk+GUzsC+OLeYYdPTlKZIXMOZA4MoBmBbLaK+j vZrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Rp9YDIaPYta60mQ/BsrLSBix9CUGWyFm/2p9lkJW98=; b=0SN8VEGw8S3klbcva9Vg0+NlKazpmmbSM06okKOnjF409WMTbWLRf9/T/9kKZAe4dZ q7NOsDoSsDe+x7rMedJKUd5lRCCVzr4ztuM1Tpgfp9sPrtLTG9GolqeBoeoFPvtbXXLw aBzUnFB9CyVep866LmIJgFC6m5fQhBkvK6eyvRS4k0ayq9b5sSix6qbXAs915pi8PXPs w9w/RH4SwjGC9c36nYE5o9web25KHL79CVuOJODj0jeNoPMq39mBdVNxUm79356p9Rav Mjg9Qb9yS6R+z1TreY7EP7VH0lLCPUk4oy0D4Qzd+6duSRfXtyL8n16n4tdEipOCV7Ck Qilw== X-Gm-Message-State: AO0yUKXBBXUFIkz7vQA3DKVOxRDaOKK/031Fmm8BardlCV0o7z1YrET/ XDbZK/C/Mfy95+HwYxEmKNc= X-Google-Smtp-Source: AK7set8kP9Z0rJKB5dCgCS4+I0rcq/FTOjDW83sG9thtM+iUS/L5zq7L6JuG4KEbZrQLK30rrmHNew== X-Received: by 2002:a92:ca4e:0:b0:315:48a5:4d3f with SMTP id q14-20020a92ca4e000000b0031548a54d3fmr1824785ilo.5.1676270496055; Sun, 12 Feb 2023 22:41:36 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id r11-20020a056e0219cb00b0030c27c9eea4sm2259531ill.33.2023.02.12.22.41.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Feb 2023 22:41:35 -0800 (PST) Message-ID: Date: Sun, 12 Feb 2023 23:41:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Simplify "1 - bool_val" to "bool_val ^ 1" Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230201012112.1300516-1-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230201012112.1300516-1-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/31/23 18:21, Andrew Pinski via Gcc-patches wrote: > For bool values, it is easier to deal with > xor 1 rather than having 1 - a. This is because > we are more likely to simplify the xor further in many > cases. > > This is a special case for (MASK - b) where MASK > is a powerof2 - 1 and b <= MASK but only for bool > ranges ([0,1]) as that is the main case where the > difference comes into play. > > Note this is enabled for gimple folding only > as the ranges are only know while doing gimple > folding and cfun is not always set when fold is called. > > OK? Bootstrapped and tested on x86_64-linux-gnu with no > regressions. > > gcc/ChangeLog: > > PR tree-optimization/108355 > PR tree-optimization/96921 > * match.pd: Add pattern for "1 - bool_val". > > gcc/testsuite/ChangeLog: > > PR tree-optimization/108355 > PR tree-optimization/96921 > * gcc.dg/tree-ssa/bool-minus-1.c: New test. > * gcc.dg/tree-ssa/bool-minus-2.c: New test. > * gcc.dg/tree-ssa/pr108354-1.c: New test. OK. jeff