From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Xp6E=37=mentor.com=Andrew_Stubbs@sourceware.org>
Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153])
	by sourceware.org (Postfix) with ESMTPS id 01E463858CDA
	for <gcc-patches@gcc.gnu.org>; Thu,  1 Dec 2022 14:42:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01E463858CDA
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.96,209,1665475200"; 
   d="scan'208";a="91386799"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
  by esa1.mentor.iphmx.com with ESMTP; 01 Dec 2022 06:42:08 -0800
IronPort-SDR: LZvOVTds3y/efC+Gasgb0uVb8NKOxlVvcMPlCS5aEDu5n1Jeehr3etrvAm0QGPkE7mkWB9TQWh
 Vnp44+0QCcGNlUZl/Q4HXstY3mHkMtyHsjFdnJpuUJ9vrwOwhLQWMC8DkX2wvPPy3CVTkY5wOf
 gGIm2JeYbYmy42CNeS82btBkQwM4k7scwq59DDmpYWqBb4hn/JHCqTsVS1IlgQuuscuhx43idL
 IPn5wDuaBxJcTy+eM0c+Beb6MtzPjUTSCeXODYFVPOXxcebX0t4A+zxUELSRnsXeMp4SYLtbE4
 aq4=
Message-ID: <b6403f5c-04c8-969f-d0db-1221ecd56bdc@codesourcery.com>
Date: Thu, 1 Dec 2022 14:42:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] amdgcn: Add preprocessor builtins for every processor
 type
To: Paul-Antoine Arras <pa@codesourcery.com>, Kwok Cheung Yeung
	<kcyeung77@gmail.com>
CC: gcc-patches <gcc-patches@gcc.gnu.org>
References: <e929111e-d5f2-8ed3-c3ec-f1280615d8fc@codesourcery.com>
 <202ee18b-90c8-830b-82a5-b705a9ec5c73@gmail.com>
 <82a884ed-ea1d-5116-fedf-42de6e22e730@codesourcery.com>
 <0600a1e2-d877-6522-15a9-0e5d0219a76b@codesourcery.com>
 <b3b7e809-537d-c2f0-c02d-b1050967edbd@codesourcery.com>
Content-Language: en-GB
From: Andrew Stubbs <ams@codesourcery.com>
In-Reply-To: <b3b7e809-537d-c2f0-c02d-b1050967edbd@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To
 svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11)
X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 01/12/2022 14:35, Paul-Antoine Arras wrote:
> I believe this patch addresses your comments regarding the GCN bits.
> 
> The new builtins are consistent with the LLVM naming convention (lower 
> case, canonical name). For gfx803, I also kept '__fiji__' to be 
> consistent with -march=fiji.
> 
> Is it OK for mainline?

You need to wrap the long line in the changelog (I'm not sure it'll even 
let you push it like that), but otherwise it looks fine.

OK.

Andrew