From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 89CB63857034 for ; Wed, 24 Aug 2022 05:24:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89CB63857034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27O5Fos7032404; Wed, 24 Aug 2022 05:24:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=pIKareLeGn1hzSyXpCg0IDCvvCol3MqF9QkoIeKzqtc=; b=Xp/5ZXkR/WSnD4JhgpUWd6PM3zvf+wXvSs9uulEcJ1vt5Uy8piKzA6P1G/Vfsy1X0NtH 5tgijtAKmZQoqFcD4YbuVHccjJywS9wJ+SzOtKFt3LnR1OWrai/C85jwWVurKTxI5Eez ovvx6IIFy0JAjfQ0i5j0z+GR78j7qIG0j4MC4voejNpOR6QSWZGrSsLbsDgyHcnKfYn0 Xg3R9HSw/iJXrV1nCMtIgSpmVi49RAXDK9O99U/bPysHza073rJhqp6R65V94cC7cTqe WEtYUkUy6XGIiOK1JhbnrS5becZ5Luh5cug4OCBAgXNUkxIgF0w6cJERM2ZGlYmn5Ryl ag== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j5dpgr5he-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Aug 2022 05:24:36 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27O5NNbK019721; Wed, 24 Aug 2022 05:24:36 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j5dpgr5ge-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Aug 2022 05:24:36 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27O5KMT2014805; Wed, 24 Aug 2022 05:24:34 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03fra.de.ibm.com with ESMTP id 3j2q893dkt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Aug 2022 05:24:33 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27O5LUtg16384298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Aug 2022 05:21:30 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 896EDA404D; Wed, 24 Aug 2022 05:24:30 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D362FA4040; Wed, 24 Aug 2022 05:24:28 +0000 (GMT) Received: from [9.197.255.133] (unknown [9.197.255.133]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 24 Aug 2022 05:24:28 +0000 (GMT) Message-ID: Date: Wed, 24 Aug 2022 13:24:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions Content-Language: en-US To: HAO CHEN GUI Cc: gcc-patches , David , Peter Bergner , Segher Boessenkool References: <2ffb2ff4-540d-3bcf-4e4e-478acbdd910d@linux.ibm.com> <20220823142620.GU25951@gate.crashing.org> From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JLDQ1zR3Dg0738MLD2e5CMO_SKjDlw4D X-Proofpoint-GUID: DmBBG3yoYQh5ukRVyCpg-q7tgyXSLJ4z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-24_02,2022-08-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=701 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208240021 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2022/8/24 13:11, HAO CHEN GUI wrote: > Hi Segher, > > On 23/8/2022 下午 10:26, Segher Boessenkool wrote: >> Hi! >> >> On Fri, Aug 19, 2022 at 10:35:54AM +0800, HAO CHEN GUI wrote: >>> --- a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >>> +++ b/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >>> @@ -1,7 +1,8 @@ >>> /* { dg-do compile { target { powerpc*-*-* } } } */ >>> -/* { dg-require-effective-target lp64 } */ >>> -/* { dg-require-effective-target powerpc_p9vector_ok } */ >>> /* { dg-options "-mdejagnu-cpu=power9" } */ >>> +/* { dg-additional-options "-mpowerpc64" { target { powerpc*-*-linux* && ilp32 } } } */ >> >> You can add this always. It is default on 64-bit systems, but it is >> simpler to just always add it: >> /* { dg-additional-options "-mpowerpc64" } */ >> >> Or are there subtargets that will error on this? > Yes, AIX fails if TARGET_POWERPC64 is set and TARGET_64BIT is not set. > So I add "-mpowerpc64" for Linux 32-bit environment. > > if (TARGET_POWERPC64 && ! TARGET_64BIT) \ > { \ > error ("%<-maix64%> required: 64-bit computation with 32-bit addressing not yet supported"); \ > } > Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all the time, but still having that has_arch_ppc64 effective target on aix? I'd expect has_arch_ppc64 check to fail on aix 32bit, the error will not be a problem (turning into an UNSUPPORTED then)? BR, Kewen