From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id EA9FF3858409 for ; Thu, 30 Dec 2021 13:51:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA9FF3858409 Received: by mail-il1-x12a.google.com with SMTP id c4so12510950iln.7 for ; Thu, 30 Dec 2021 05:51:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nE5dklgs4z83yCG2J/pkz8iFau3EYgTt8cjaBPRA0Ew=; b=DP8AY3mYkuwok3TVYzMLD2uPR6cpGpmleUH+CCkrNcBx+qaek11pGpRyevs8BXVYqs SF7Tq7C4KhurM5WH3/RlYfGoyRPDYFJhCozgy+awBGc+cL9EGTF1q8Mi7dHrsVLAooKW o1FYuIeAA9gC6sMLuDooSBMR7NIQB7y3Ef4WSOUpqmZbZWyfXpFzzh1ADYx1+2LESmWM HtbkyPvF/7lGzf9f9ShEtsdHrA3U6pucOBhhC6rT/WsxFdEsk+VXvUegU/9tOfkUs7iD UoL1W+BpzEQrQ/jgVdR/FgC+l1pWNcUkqqSbLeCVUkAv62GT/4kOMLrzdm7Rcz9cbTjm Unsg== X-Gm-Message-State: AOAM531nN3OYLBQZfoa8Qg2bNAQz51aHvQeReeGaB77wxEVN+KUqGKJA DhFb73zvKwZBs9iTjbGrg+z9Y61FNov6aQ== X-Google-Smtp-Source: ABdhPJwPaaglzZTpFekpxDo2PX6SsrMkbSyZ8elH6S1TmP/uumLSYChDwgKCJFlr9i78MioRHZf+jA== X-Received: by 2002:a92:c20f:: with SMTP id j15mr13581335ilo.258.1640872264298; Thu, 30 Dec 2021 05:51:04 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id v5sm10315511ilu.77.2021.12.30.05.51.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Dec 2021 05:51:04 -0800 (PST) Message-ID: Date: Thu, 30 Dec 2021 06:51:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] fixed testcase fail gcc.dg/analyzer/pr103526.c leak Content-Language: en-US To: shihua@iscas.ac.cn, gcc-patches@gcc.gnu.org Cc: sinan@isrc.iscas.ac.cn, jiawei@iscas.ac.cn, yulong@nj.iscas.ac.cn References: <20211230022117.944-1-shihua@iscas.ac.cn> From: Jeff Law In-Reply-To: <20211230022117.944-1-shihua@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Dec 2021 13:51:09 -0000 On 12/29/2021 7:21 PM, shihua@iscas.ac.cn wrote: > From: LiaoShihua > > following 'false' branch in line 20, 'tmp.word_state' leaks in line 26. So free 'tmp.word_state' before return 'rval'. > > gcc/testsuite\ChangeLog: > > * gcc.dg/analyzer/pr103526.c: Umm, isn't the whole point of the test to verify that the analyzer properly detects the non-free'd pointer as escaping via the return value? Jeff