From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] RISC-V: Avoid splitting store dataref groups during SLP discovery
Date: Fri, 24 May 2024 17:34:53 -0600 [thread overview]
Message-ID: <b6bca1ea-b60b-4f08-b502-f99337a6be3a@gmail.com> (raw)
In-Reply-To: <orqo0618-ro35-qpq1-s85o-34o211475301@fhfr.qr>
On 5/23/24 11:52 PM, Richard Biener wrote:
>
> This worked out so I pushed the change. The gcc.dg/vect/pr97428.c
> test is FAILing on RISC-V (it still gets 0 SLP), because of missed
> load permutations. I hope the followup reorg for the load side will
> fix this. It also FAILs gcc.target/riscv/rvv/autovec/struct/struct_vect-4.c
> which does excessive assembly scanning on many functions - I'll leave
> this for target maintainers to update - there's one or two functions
> which we now expect to SLP.
Yea, folks got a bit carried away with the scan body capability.
Someone will have to follow-up behind you and clean this up a bit.
Thanks for checking it agains the CI system. While it's a bit on the
slow side, we are finding its helping catch real issues and keeping the
testsuite cleaner WRT FAILs.
jeff
next prev parent reply other threads:[~2024-05-24 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 5:52 Richard Biener
2024-05-24 23:34 ` Jeff Law [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-23 14:01 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6bca1ea-b60b-4f08-b502-f99337a6be3a@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).