From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 1AF463858D29 for ; Fri, 24 May 2024 23:34:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AF463858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1AF463858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716593697; cv=none; b=vrgT904qQsp4cniYegUcOQ6VVQ5jVRL0TO41VctPi2hlzFR/OnhZb84y3ONNfrPjwBifNgtbmDq6Z9KFzwj8TSUiv/l45pYeb+BN4IOeDvO/nbtVBVbmwH/NCuId9RSbw7LDuGJ1PQj7SKSETtTsx1GIH3CM2j9dYOyCcZxQWrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716593697; c=relaxed/simple; bh=WbUki25BmKmUzXtaoFnGawdAbaf/6+xAuJ3oZbuNmOk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UFF27PNDrsC9iMqG0RzzoFtm2sudWGr+rFJMQGhae7yiUYZtdZQg4dUv6oSxJFjFAPMb3xTfyHmXvDIH1KAJeELWVQTtqo2rsX8pl+jYwGRV1aDEcYPk+ay8SZI0uH3T8ejfqhtkh1ObM+5aRLt1LkPkdsVo+xot6HRJll0m914= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1f33d84eaefso18586225ad.3 for ; Fri, 24 May 2024 16:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716593695; x=1717198495; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=abMRK3IvUwA7T49HtbFHtlZ0kFmD31T1++zxtHnCWsk=; b=Cmhq5b8+q0seqk+gvlnD/T02MHBFJmZb85YrAcHTW/FkDJ7dJ/qz2d3NuHhXpxd0Ht I0vxffaKdGtTxnYVedl+kQNKKNbXNou0TW1zZ2M/2hnbsG/LtROvSeG7xKrypI2pH918 1mDDMedyvLZ3nx+SDa80t5Pbygb18YK3PnPNniHv9Ry5h8H14TFjoXKAHL9fRDRx2MZu 8n5Z+4fTtpSk1HpzJ7WgDgfNAxpUnBjWs1MsQk3NKRaf/PjVtsG/4gqxloIOlUb/W3Yq QbU1UVF7LkBXkO+thfFbzXluS/t7DTnDASZ5NwdSa6qKMKUewAmYefpfaAhJw4fhsFZz NFWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716593695; x=1717198495; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=abMRK3IvUwA7T49HtbFHtlZ0kFmD31T1++zxtHnCWsk=; b=uH0JXLXjfIFWYG67JmoshpRNS6GoAYAExmm6R1EFI2NSDH4F4neBilqJyNPJ4v1Rt7 hdCfTf1QT5/4Fo9MFbpLuQwFWFR4bxdwxXn18Lj9udfJMV5VsIlNvX/2vPfpok8nBSLU yBoP9Hfiw1WBP9wrk7TA+ffbSoYN81YdfPst+6Kv6GXSZRfrdnJmN8pIEw7O1sQLtmgD dob3uFcVXKuqGqaS/2RRCOUMWVzASkTAwcKSUkSUOEKxA3OOpVqq0XyisgL63WBF91s7 LjBOLL8K4Y5fhzTix++EbRahrpPotdwiFCLk4N9iMoW2DpHiMruorhuM4Z/kWMZ/o7NG 1Dqg== X-Forwarded-Encrypted: i=1; AJvYcCVSe37i4AooBAqHr9g4WyXtyJumvDidMnUMefwM5KF+7KAY7vXIZrHFiNUJmJEZiGKd3itZ1XYNU7Frn3JkTp/ELOoyg1ggDQ== X-Gm-Message-State: AOJu0YyT97e6CZObAXr8WqLBKt6TzURfc3eAi9XL75adLwavPU34jLij 5oEo+B0vsHBX0jMDjvHJly2psB6aynNjF2572fkuMsaJ9OJlhuRlQmVsHTKl X-Google-Smtp-Source: AGHT+IEx4tD4NLPUTw1OCFbzwc4VmbROA4QVBmXtIPk6UI7CAzGNhZ7h4A+CEQvO/CyfBmAlvc56iQ== X-Received: by 2002:a17:902:cecd:b0:1f3:4225:bb79 with SMTP id d9443c01a7336-1f4486c5624mr55878495ad.2.1716593694703; Fri, 24 May 2024 16:34:54 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c75e624sm19234425ad.47.2024.05.24.16.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 16:34:54 -0700 (PDT) Message-ID: Date: Fri, 24 May 2024 17:34:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] RISC-V: Avoid splitting store dataref groups during SLP discovery Content-Language: en-US To: Richard Biener , gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/23/24 11:52 PM, Richard Biener wrote: > > This worked out so I pushed the change. The gcc.dg/vect/pr97428.c > test is FAILing on RISC-V (it still gets 0 SLP), because of missed > load permutations. I hope the followup reorg for the load side will > fix this. It also FAILs gcc.target/riscv/rvv/autovec/struct/struct_vect-4.c > which does excessive assembly scanning on many functions - I'll leave > this for target maintainers to update - there's one or two functions > which we now expect to SLP. Yea, folks got a bit carried away with the scan body capability. Someone will have to follow-up behind you and clean this up a bit. Thanks for checking it agains the CI system. While it's a bit on the slow side, we are finding its helping catch real issues and keeping the testsuite cleaner WRT FAILs. jeff