From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id CD5A73858D28 for ; Tue, 1 Aug 2023 23:52:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD5A73858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1b9c5e07c1bso53166035ad.2 for ; Tue, 01 Aug 2023 16:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690933941; x=1691538741; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KgqkN5kWA7K93BWMcbzEl9g4U8N7O2jOd1zSEeL8Q8w=; b=Jkg0F75wsa8MB5LSTAC+WkccQEMulQGT8SujuVRY7jsneQP7Ya80zRjDXBldbvR6zQ atLYe4BMJK9FudauLttMDsB+dEaAA6a60g6EPFGQ1Dwvmr79v084iWTJUudjW2SWTYgq judzMNU4lT3tyHhuRiW2KtlIXqivosjy1KnP8g15O14y+NblEbMxk2h1fHtlaO9G0dSj 6Tnw4Ac12+AVJXlU/+8dlSVtQk0xcJCrNUZbZjgzP/kvxqwOVAJ4DyvFjWYW0HffwXiR 2TB9mD9s6pstAmH7rZC6KKIt6FvZd8W1bEfOZ5rApDA7qnR1yZ1oWNISEqZM4pKgI7V2 ejDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690933941; x=1691538741; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KgqkN5kWA7K93BWMcbzEl9g4U8N7O2jOd1zSEeL8Q8w=; b=HXuanyN1sL+8t8X+9BJWeWaxJHx4WBF9OnwLXXzRDI9U1XY/VhTTnFcfY6BZ5V5JZl 6sBUH8eT6PaQegxn1sYkBFvoSis/6YLVEyF+JP+EAdItprBGWNuxZA+RyRWmM/xj8iwx lxnLOKqcZYcszIEcnozpceJ6Wf/xYnMWcPqCccpRDQ32Vm511wOoVZ1VLGYSAuUsgaSQ zVmINNigOcbHZFzZqLnaVeTz/ZmW9z/9ucCOTpGrlh6bFmlcAyQne3ZZy+7Stm8kEx7R ziyLhc1NiKxNVHsrFkXN8a+fAHI5oZgW9wezOgMYv1ZBC2TYIXoT7YWZhXYF5nNLsVLL XQlw== X-Gm-Message-State: ABy/qLYtgo/GhvBv6Vc0AvBWpnwwhEFTgmJ/AS9LAkZ9R2yG0idtJngw l9TCWHgjmm56Mz/jHO9rv2w6WOdTrI3onA== X-Google-Smtp-Source: APBJJlHvyaDNnfWo3QPJ5duhjM90/4lzbZyjkP7OvdQ/oDeqcXpmB7yuSVkmZ40FYRu2qtZG3ihinA== X-Received: by 2002:a17:903:22c8:b0:1bb:b91b:2b40 with SMTP id y8-20020a17090322c800b001bbb91b2b40mr17090700plg.60.1690933940701; Tue, 01 Aug 2023 16:52:20 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id kb14-20020a170903338e00b001bba1188c8esm10966819plb.271.2023.08.01.16.52.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 16:52:20 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 17:52:19 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: RISC-V: Folding memory for FP + constant case Content-Language: en-US To: Vineet Gupta , Philipp Tomsich Cc: Manolis Tsamis , Jivan Hakobyan , gcc-patches@gcc.gnu.org References: <3c1f0f8a-34ed-abb2-8a49-3083a2cc55d2@gmail.com> <61c9b9c2-f52e-2b4e-6d02-62c991603c39@gmail.com> <64233838-fe5e-458d-1eaf-3025b5448d85@rivosinc.com> <91c12503-c288-5b81-8941-cc62bab2ee98@gmail.com> <73dc8b97-7a7b-d9a0-2e8e-b4a5aaa3ee93@rivosinc.com> <40176a5c-382d-809d-a4b1-06c6541c3670@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/1/23 17:38, Vineet Gupta wrote: >> >> Also note that getting FP out of the shift-add sequences is the other >> key goal of Jivan's work.  FP elimination always results in a >> spill/reload if we have a shift-add insn where one operand is FP. > > Hmm, are you saying it should NOT be generating shift-add with SP as > src, because currently thats exactly what fold FP offset *is* doing and > is the reason it has 5 less insns. We should not have shift-add with FP as a source prior to register allocation because it will almost always generate spill code. jeff