From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by sourceware.org (Postfix) with ESMTPS id BA8CB3858CD1 for ; Thu, 20 Jul 2023 21:31:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA8CB3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1a28de15c8aso975031fac.2 for ; Thu, 20 Jul 2023 14:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689888689; x=1690493489; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4h93G7fcnnKci66eh1468Cz0OwRzddIqDL2Ou7eKu80=; b=KxrvY1PkqzTlQVXIRJCVnZvdwrhThEpCXlaJDd58apvazaBaFFY5FC1ChBf3HM2aBz i6rLRx7VUDWbjW17aAVKleV9WWlQar+0mwxpKzMLHsN3bvZdF8ANo8TxOKByp1uJEQ6k 5BfPJISb/foQcU74s2l4rrwhGl5D7xMuRTak8uUpCsqOdOKMRLGig3Cp91zaVMB0fvfP Q0oB37xifjTHcC+N7x72ZW1bNXJOZ2ORxzULHakRpSFq1z/7SrXtOVEddIQHLH3r7dra xC6out0+ZJ5DZ5XzYOKHe/Y3P8rHalq0FBkUYnq4XIvSw3UJDfJUo6aI55A3IFjb3pCe OHmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689888689; x=1690493489; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4h93G7fcnnKci66eh1468Cz0OwRzddIqDL2Ou7eKu80=; b=kPz2LJNhZrcXIU7xmxXZK5nKOuKKHi0MRuorYu1hu5DIxlZfQmcpWGiboHRHXF2zid yqk3xtw+GmrETEfU/tHb+ARNGLmGx9KovEsIIoribyvs3a/YTOJezjWkSpLwTR+9KpDe /t1vgaXa0ZThUYd0zAYqErIbLWArhYp5Nor6boIuJUKGe6G3JvWhg3PyJHgHHkymbneU G05NK7XMOgUAA7sv8yiHhjE6509GW9ZS/ctAAAjYMYkEv4X2FtNj8XZ48ab6x9phwMxd UNQHN57lTcmd5rF6QS8UvRIxKToPyt+P/x5eHSQ/Gggre/G5GfryODYc9dtV5obcNELG bD8g== X-Gm-Message-State: ABy/qLZTzhhWFBfFvbiub7bbB/B31fVG7e6z7hw+E59EYCDSc2UOION/ CmJ3/dAsf9RQAAxnbsrSJKc= X-Google-Smtp-Source: APBJJlFkA10swkIfqEXUWK0+itbIEyd/b40I9/mP8iy5LspnIRy92io9Q3roJVfSCijffAXdwMTZUA== X-Received: by 2002:a05:6870:3508:b0:1b7:3359:58b2 with SMTP id k8-20020a056870350800b001b7335958b2mr938937oah.39.1689888688798; Thu, 20 Jul 2023 14:31:28 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id x22-20020aa784d6000000b0066a6059d399sm1615481pfn.116.2023.07.20.14.31.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 14:31:28 -0700 (PDT) Message-ID: Date: Thu, 20 Jul 2023 15:31:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] tree-optimization/110742 - fix latent issue with permuting existing vectors Content-Language: en-US To: Richard Biener , gcc-patches@gcc.gnu.org Cc: richard.sandiford@arm.com References: <20230720123851.61BA33857711@sourceware.org> From: Jeff Law In-Reply-To: <20230720123851.61BA33857711@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/20/23 06:38, Richard Biener via Gcc-patches wrote: > When we materialize a layout we push edge permutes to constant/external > defs without checking we can actually do so. For externals defined > by vector stmts rather than scalar components we can't. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > PR tree-optimization/110742 > * tree-vect-slp.cc (vect_optimize_slp_pass::get_result_with_layout): > Do not materialize an edge permutation in an external node with > vector defs. > (vect_slp_analyze_node_operations_1): Guard purely internal > nodes better. > > * g++.dg/torture/pr110742.C: New testcase. OK jeff