From: Cesar Philippidis <cesar_philippidis@mentor.com>
To: Nathan Sidwell <nathan@acm.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [nvptx] propagating conditionals in worker-vector partitioned loops
Date: Fri, 09 Dec 2016 14:08:00 -0000 [thread overview]
Message-ID: <b750ea98-11b0-6623-31ce-a779f1b3c72c@mentor.com> (raw)
In-Reply-To: <2d3d57d2-e5a8-04e9-7ad1-72e4b21beae4@codesourcery.com>
Ping.
On 10/26/2016 03:29 PM, Cesar Philippidis wrote:
> Currently, the nvptx backend is only neutering the worker axis when
> propagating variables used in conditional expressions across the worker
> and vector axes. That's a problem with the worker-state spill and fill
> propagation implementation because all of the vector threads in worker 0
> all write the the same address location being spilled. As the attached
> test case demonstrates, this might cause an infinite loop depending on
> the values in the vector threads being propagated.
>
> This patch fixes this issue by introducing a new worker-vector
> predicate, so that both the worker and vector threads can be predicated
> together, not separately. I.e., instead of first neutering worker axis,
> then neutering the vector axis, this patch uses a single predicate for
> tid.x == 0 && tid.y == 0.
>
> Is this patch ok for trunk?
>
> Cesar
>
next prev parent reply other threads:[~2016-12-09 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 22:29 Cesar Philippidis
2016-12-09 14:08 ` Cesar Philippidis [this message]
2016-12-09 17:27 ` Bernd Schmidt
2018-04-11 8:59 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b750ea98-11b0-6623-31ce-a779f1b3c72c@mentor.com \
--to=cesar_philippidis@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).