public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: FX <fxcoudert@gmail.com>
Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Subject: Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs
Date: Tue, 11 Jan 2022 23:11:46 +0100	[thread overview]
Message-ID: <b789fe91-cb8e-7a0a-9e6b-2bf7e4332aa4@gmx.de> (raw)
In-Reply-To: <BB32586F-E4BC-4DE1-881C-36028AF64E4E@gmail.com>

Hi FX,

Am 11.01.22 um 23:04 schrieb FX via Fortran:
> Hi Harald,
>
>> I think this patch breaks the testsuite
>
> On what platform? It regtested fine on x86_64-pc-linux-gnu

I looked at gcc-testresults and find e.g.

https://gcc.gnu.org/pipermail/gcc-testresults/2022-January/747938.html
https://gcc.gnu.org/pipermail/gcc-testresults/2022-January/747935.html

which is x86 (64 and 32 bit) by H.J.; plus some more.

Maybe H.J. can explain what is different from your platform?

>
>> since the directive
>> ! { dg-additional-sources signaling_1_c.c }
>> should rather read
>> ! { dg-additional-sources "signaling_1_c.c" }
>
> I find plenty of evidence saying it’s allowed (just quoting a few, but there are a lot):
>
> ./gfortran.dg/PR94331.f90:! { dg-additional-sources PR94331.c }
> ./gfortran.dg/global_vars_c_init.f90:! { dg-additional-sources global_vars_c_init_driver.c }
> ./gfortran.dg/c_char_tests.f03:! { dg-additional-sources c_char_driver.c }
>
>
> FX

Harald

  reply	other threads:[~2022-01-11 22:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-02 10:50 FX
2022-01-09 10:52 ` FX
2022-01-09 19:34   ` Mikael Morin
2022-01-10 12:04     ` FX
2022-01-11 22:01 ` Harald Anlauf
2022-01-11 22:04   ` FX
2022-01-11 22:11     ` Harald Anlauf [this message]
2022-01-11 22:32       ` FX
2022-01-12 10:23         ` FX
2022-01-12 10:34           ` Jakub Jelinek
2022-01-12 11:03             ` FX
2022-01-12 11:06               ` Jakub Jelinek
2022-01-12 11:55                 ` FX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b789fe91-cb8e-7a0a-9e6b-2bf7e4332aa4@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=fxcoudert@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).