From: Diego Novillo <dnovillo@google.com>
To: Rafael Espindola <espindola@google.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [lto][patch] Move the call to execute_all_ipa_transforms to cgraphunit.c
Date: Tue, 11 Nov 2008 22:54:00 -0000 [thread overview]
Message-ID: <b798aad50811111453m7da74c0aradf8dfe50409fa86@mail.gmail.com> (raw)
In-Reply-To: <38a0d8450811110921t4c619461u2f934ddcdc3df5e@mail.gmail.com>
2008/11/11 Rafael Espindola <espindola@google.com>:
> So, which one is your favorite? :-) Assuming disabling the pass has no
> regressions, should I commit that?
Yes, thanks. Converting pass_set_nothrow_function_flag into an IPA
pass is the right approach. In fact, I like Jan's idea of bundling it
with the const/pure pass. However, that can wait. Could you open a
PR for it?
> And if it has? Should I debug the above problem?
No, it would be too much hassle for no gain. The pass must go away.
Diego.
next prev parent reply other threads:[~2008-11-11 22:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 17:31 Rafael Espindola
2008-11-11 20:23 ` Jan Hubicka
2008-11-11 22:49 ` Rafael Espindola
2008-11-11 22:53 ` Jan Hubicka
2008-11-11 23:11 ` Diego Novillo
2008-11-11 23:18 ` Jan Hubicka
2008-11-11 23:41 ` Rafael Espindola
2008-11-11 23:59 ` Jan Hubicka
2008-11-12 0:01 ` Diego Novillo
2008-11-12 0:04 ` Jan Hubicka
2008-11-12 0:57 ` Jan Hubicka
2008-11-12 2:02 ` Diego Novillo
2008-11-12 10:01 ` Rafael Espindola
2008-11-12 16:02 ` Jan Hubicka
2008-11-12 16:35 ` Jan Hubicka
2008-11-11 23:53 ` Diego Novillo
2008-11-11 22:54 ` Diego Novillo [this message]
2008-11-11 23:14 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b798aad50811111453m7da74c0aradf8dfe50409fa86@mail.gmail.com \
--to=dnovillo@google.com \
--cc=espindola@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).