From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 187243858C54 for ; Wed, 7 Jun 2023 02:53:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 187243858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-25669acf1b0so5921619a91.0 for ; Tue, 06 Jun 2023 19:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686106408; x=1688698408; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1uNhhUL9WAuyP2kb3qxSe7GgyPry0sIyyvLCl4aGGNM=; b=D6f78YTkpyi8lmXHRRMDqm6+yRtFv/L4jKABB+XKYGoGzQe/RPjuEtVJTSh8cq0k4i R8Xr+caQRtxgl8cCf/+LrbEM6+LC/31JkOsBqNLTfw9F3nuKv2BSSyI5xRj7oM94oxKj g4GPNyJHws38fy5GrNjzuRkGQ2iCITpfy0ERfhW0UrB4nE4h/zbUXz+PAPFy9x/JqlTu zlGgmX9qEdr6alBiHZ2G31IMs46p1MxUBqwY1cRZNohiDU0bSHSYQEBvm0egB66XqU+v ZfmX4dyt++fUJToHldM0rNm8adXLrQwp8UrkXPaqW7DOE7USaGc9LG/xO/iicpjbUPrc m+JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686106408; x=1688698408; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1uNhhUL9WAuyP2kb3qxSe7GgyPry0sIyyvLCl4aGGNM=; b=FTrdvPwHh/d8inBHKGWmKhu/0ltLEDNRSt2520ib2lx7yGSm7zI3ti8IL0Ht+ACEDj ifq7NabQPbVAE/M27Xgr6jREBjvw5s3i2alZmPsguA/JqsPqGszQyFF5pxc4ePTTXhV6 oCiUaunZM62F5PUC2x9BxJBeqqcvS8f6UiQjpak37QYA3TubTaceRzd/qjl4LlLwYI3G A4nsv3HVORZITKxgSFmuOm1ezvdqxhYQJB6gHWC8WmtXhEI3N+m68FVlAgbm/x6KfjTF 311th2+t5GRZHSI+2lWKeVlxfJ/1PDlWUhlgVHxXqjScJKSnn+i2EvxWp8JL799wbNy3 wjBw== X-Gm-Message-State: AC+VfDzRWsZjb8ACis0RiTrnRzdfZPIcYig261M+lXCsVpTAAZE+F6jA /YFB6oixTUneKvFY5xMFnRAKhGxJfL8= X-Google-Smtp-Source: ACHHUZ5e+nXCboTPjttLQYqUNopK3a6O3LruKSlk2068relbTvltfOvS9SC9b+f2rW3QQ//jP/1M+Q== X-Received: by 2002:a17:90b:905:b0:259:bf1:3030 with SMTP id bo5-20020a17090b090500b002590bf13030mr3439703pjb.42.1686106407921; Tue, 06 Jun 2023 19:53:27 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id ev21-20020a17090aead500b00256833cd9a4sm215428pjb.54.2023.06.06.19.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jun 2023 19:53:27 -0700 (PDT) Message-ID: Date: Tue, 6 Jun 2023 20:53:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] For the `-A CMP -B -> B CMP A` pattern allow EQ/NE for all integer types Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230606210710.2992237-1-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230606210710.2992237-1-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/6/23 15:07, Andrew Pinski via Gcc-patches wrote: > I noticed while looking at some code generation issue, that forwprop > was not handling `-a == 0` for unsigned types and I was confused why > it was not. > r6-1814-g66e1cacf608045 removed these from fold because they > were supposed to be already handled by the match.pd patterns > but it was missed that the match.pd patterns checked > TYPE_OVERFLOW_UNDEFINED while fold didn't do that for NE/EQ. > This patch removes the restriction on NE/EQ on TYPE_OVERFLOW_UNDEFINED. > > OK? Bootstrapped and tested on x86_64-linux-gnu. > > gcc/ChangeLog: > > PR tree-optimization/110134 > * match.pd (-A CMP -B -> B CMP A): Allow EQ/NE for all integer > types. > (-A CMP CST -> B CMP (-CST)): Likewise. > > gcc/testsuite/ChangeLog: > > PR tree-optimization/110134 > * gcc.dg/tree-ssa/negneq-1.c: New test. > * gcc.dg/tree-ssa/negneq-2.c: New test. > * gcc.dg/tree-ssa/negneq-3.c: New test. > * gcc.dg/tree-ssa/negneq-4.c: New test. OK. jeff