From: Jeff Law <jeffreyalaw@gmail.com>
To: Patrick O'Neill <patrick@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] g++: Add require-effective-target to multi-input file testcase pr95401.cc
Date: Thu, 9 Nov 2023 18:34:38 -0700 [thread overview]
Message-ID: <b7a727e4-be87-4b4f-91da-80ee3801b95c@gmail.com> (raw)
In-Reply-To: <20231103061849.79159-1-patrick@rivosinc.com>
On 11/3/23 00:18, Patrick O'Neill wrote:
> On non-vector targets dejagnu attempts dg-do compile for pr95401.cc.
> This produces a command like this:
> g++ pr95401.cc pr95401a.cc -S -o pr95401.s
>
> which isn't valid (gcc does not accept multiple input files when using
> -S with -o).
>
> This patch adds require-effective-target vect_int to avoid the case
> where the testcase is invoked with dg-do compile.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/vect/pr95401.cc: Add require-effective-target vect_int.
Sorry, I must be missing something here. I fail to see how adding an
effective target check would/should impact the problem you've described
above with the dg-additional-sources interaction with -S.
Jeff
>
next prev parent reply other threads:[~2023-11-10 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 6:18 Patrick O'Neill
2023-11-10 1:34 ` Jeff Law [this message]
2023-11-10 18:00 ` Patrick O'Neill
2023-11-19 4:08 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7a727e4-be87-4b4f-91da-80ee3801b95c@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=patrick@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).