From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id 8BEF63858D1E for ; Fri, 10 Nov 2023 01:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BEF63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8BEF63858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699580082; cv=none; b=baiI2QISKi9aXR4A9RJkFixldHxDGCcgN09XskuSAlTwzfboHMwWkt0b4iYxv28fv/TAuYW3P4ZUcWLVPkAYCJ9jbnByBJxx50dTyAILRt1G2Z1AsAQEg0UWYi2vUqPQNoVRMq+nJiIz8zmyIS/3T+y1YOITK4oBC4YBx2pf9vI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699580082; c=relaxed/simple; bh=n0j9of11kVXGMdVDtJh/Kd3GWJfkop8Trk+4R2O/bq0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UlPR12SXHOYeFYdpQBAwxotNqk9f53X/0vbdOFwNdtqr0ssY+9DUFLYA4/jEw12pjG82X4rTrNCdCfAbzULgmzI4rtUS4ZPX+1RBeSvCtOzHioZoq6weDeBJXiSRwNlO01zaIcq7x1ntilZbFkKeBHOdHyLRs2fc/0CJxC2N6qs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7ac7b2b1e99so57562539f.2 for ; Thu, 09 Nov 2023 17:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699580080; x=1700184880; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pDQVYf+KI5AITi9cqNJlWoro8v8WebusepmV5DQ5QWc=; b=Efz05PvFR/y5XYUtTO0CdFX1ZOfrPYzmKARWPNvHRyw5hvC939gCpH155cC9OPuDu9 5i88vIpXShtHT+PJfpGOQs6oQawGjKwdw/MSjmz9eB08TXKJ8vYUH3T70J1mYuONbjAH p7NsbZz/Q1XKYaQ36AiKlNBUzSVcXjpmbi9P2YkG4VxVfXUfQb1f4LSiqizIyMydeks3 8t+IqWNfYQd9NjqNQB1X/5CVhrsN2HzwtCEuiePs9M1SkKzgdGIa/Wzk3O8INp6czxe/ WUhgIkiENYCXnY9+7u0le7dxYQlFNne7WWszpCD6jpFTyXQSTw2o/eRVbMrX+bnzNXDp wxTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699580080; x=1700184880; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pDQVYf+KI5AITi9cqNJlWoro8v8WebusepmV5DQ5QWc=; b=u39GT2Yo1KtYTlL6zh2efRVIR7onxDzZIa9E2JNe06mIerPP7EVYaJH7p4u+uPfd3X RCRHb3KjrLkbv/BFJjuRxyRzjlYZWRYhfNJjKlGVdcdiiu//AP/6HhMevdjZ3QutpcD+ qhJ/zPui+zadRYE2OUi6zfEYrSSbcSpV2jT1YORZpId9fzEc6tI6VQI06rdnfhfbY79P TCJZmlEQgcIeMb5VwZ8VKVCoeY43DFEAEFbyYnb0OtohxNKSGyiFoskhOhAjYeGJdyJq FuS3IEQPouCKwbXNlEu7AB+adEIg1KPZRufBLdslJqztjSIB8rIrpoW0k44IqWYRjH31 GgwA== X-Gm-Message-State: AOJu0YzlDHr4xtcXrwDtRe6Me6Gp7FCmzvx8q2v+OCNMpUNYIwUoJ2Di 1XW2Ok5OGS8Ugp7+cqHrbTw= X-Google-Smtp-Source: AGHT+IGUd1O5gwMfSNB2As2EaP8fG8Hn06rkf2fGfAYKcQnrz0gQ974TyymVIeRAlIJCnnGL118aiw== X-Received: by 2002:a92:c54e:0:b0:359:42b0:cb02 with SMTP id a14-20020a92c54e000000b0035942b0cb02mr6961359ilj.21.1699580080629; Thu, 09 Nov 2023 17:34:40 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id fw8-20020a0566381d8800b0042b1dd89b0bsm4169648jab.155.2023.11.09.17.34.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 17:34:40 -0800 (PST) Message-ID: Date: Thu, 9 Nov 2023 18:34:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] g++: Add require-effective-target to multi-input file testcase pr95401.cc Content-Language: en-US To: Patrick O'Neill , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20231103061849.79159-1-patrick@rivosinc.com> From: Jeff Law In-Reply-To: <20231103061849.79159-1-patrick@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/3/23 00:18, Patrick O'Neill wrote: > On non-vector targets dejagnu attempts dg-do compile for pr95401.cc. > This produces a command like this: > g++ pr95401.cc pr95401a.cc -S -o pr95401.s > > which isn't valid (gcc does not accept multiple input files when using > -S with -o). > > This patch adds require-effective-target vect_int to avoid the case > where the testcase is invoked with dg-do compile. > > gcc/testsuite/ChangeLog: > > * g++.dg/vect/pr95401.cc: Add require-effective-target vect_int. Sorry, I must be missing something here. I fail to see how adding an effective target check would/should impact the problem you've described above with the dg-additional-sources interaction with -S. Jeff >