From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id EF7EF3858D32 for ; Wed, 27 Dec 2023 11:21:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF7EF3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF7EF3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703676070; cv=none; b=tERjleiR5/UsTK2GBwO8OCCNDeL14GlW5FXG5XKGvu3zIYX1s+Feqr34U/iL6YTfLo53pb6Vx/V472FaU7Tzelu7baOSbKl5mfzNc+41jeLleGHe1t1+mHuRwyHh7wQxhwOgOFg7o6rILOskvWieRNUL/ZjRYKHa+9rQ2h7FLAA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703676070; c=relaxed/simple; bh=f9PXylvL17QFLUapbzGGNFBITH1L8Qu67vS5x/Cz0Ds=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=Q0nvAPqiw4eS2W67lTCPdIcMRuvb1VZ76RkTMtSQE8WUTUc3G3cVNj9S/kdriZziwMj909agITJ7pajqpKCB74CnHeAGv8Wh0e8x0ZfEmeOxgV77OsXxnZ8YxEpzK4k+PflH6jsYQLpnNVVj4ibV+u8VdiX7mgdbUwOrUi7AANg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1703676066; bh=f9PXylvL17QFLUapbzGGNFBITH1L8Qu67vS5x/Cz0Ds=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=AWcZXxvisscq6zpXXvX3XrgJx2bafJ3/AtdGf31syNZyxFDoJm1ZyAGN6qVRMU3pj oaUHDkSek0TqSG2Q/Q2sV/qv70mpCX4C4Cwq+AAxFatoUdbZe3yohy6tEud5Po3HBu Fg2qCTtSjdpoHDPonkpvuGML5k97uv7ovifHwtSM= Received: from [192.168.124.20] (unknown [113.200.174.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 8BF5566997; Wed, 27 Dec 2023 06:21:05 -0500 (EST) Message-ID: Subject: Re: Ping: [PATCH] LoongArch: Replace -mexplicit-relocs=auto simple-used address peephole2 with combine From: Xi Ruoyao To: chenglulu , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn Date: Wed, 27 Dec 2023 19:21:02 +0800 In-Reply-To: <1885a58d-033a-5ebb-b18a-5958970cc024@loongson.cn> References: <20231212064754.6623-1-xry111@xry111.site> <64af9171-de9f-df27-1a84-b31fd0876a82@loongson.cn> <64c1875873aee3d8f196a4dd84fdf9f6fb3ee53d.camel@xry111.site> <8bb6e0c3-8e3c-7dc4-947d-fd338725fe16@loongson.cn> <0ca9482388b17b964b37a535ddd7c3e64b11fd93.camel@xry111.site> <1885a58d-033a-5ebb-b18a-5958970cc024@loongson.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2023-12-27 at 11:59 +0800, chenglulu wrote: > +FAIL: gcc.dg/pr86617.c scan-rtl-dump-times final "mem/v" 6 >=20 > In r14-6818 the issue persists. I kind of chased the code and found that = the problem is like this: > =C2=A0=C2=A0volatile unsigned char u8; >=20 > =C2=A0=C2=A0void test (void) > =C2=A0=C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0u8 =3D u8 + u8; > =C2=A0=C2=A0=C2=A0=C2=A0u8 =3D u8 - u8; > =C2=A0=C2=A0} >=20 > $./gcc/cc1 test.c -o test.s -fdump-rtl-all-all -fdiagnostics-plain-output= -Os -fdump-rtl-final -ffat-lto-objects >=20 > test.c.301r.outof_cfglayout >=20 > =C2=A0(insn 7 6 9 2 (set (reg:DI 80 [ u8.0_1 ]) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(zero_extend:DI (mem/v/c:= QI (symbol_ref:DI ("*.LANCHOR0") [flags 0x182]) [0 u8D.2193+0 S1 A8]))) "vo= latile.c":5:11 459 {simple_load_uextdiqidi} > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(nil)) >=20 > test.c.302r.split1 >=20 > (insn 27 6 28 2 (set (reg:DI 98) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(unspec:DI [ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0(symbol_ref:DI ("*.LANCHOR0") [flags 0x182]) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0]= UNSPEC_PCALAU12I_GR)) "volatile.c":5:11 -1 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(nil)) > (insn 28 27 9 2 (set (reg:DI 80 [ u8.0_1 ]) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(zero_extend:DI (mem:QI (= lo_sum:DI (reg:DI 98) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(symbol_ref:DI ("*.LANCHOR0= ") [flags 0x182])) [0 S1 A8]))) "volatile.c":5:11 -1 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(nil)) >=20 > The volatile property of the mem here is gone, so the test fails. Phew. I guess I couldn't reproduce it because I have Jeff's ext-dce patch in my local repo, which removed the zero_extend... I'll rework this patch. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University