From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id A169A3851C02 for ; Wed, 26 Jan 2022 02:17:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A169A3851C02 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20Q2AN69027702; Wed, 26 Jan 2022 02:17:32 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3dtvxf09kd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Jan 2022 02:17:32 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 20Q2DlmA002731; Wed, 26 Jan 2022 02:17:31 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 3dtvxf09jx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Jan 2022 02:17:31 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 20Q281Nc020450; Wed, 26 Jan 2022 02:17:29 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03fra.de.ibm.com with ESMTP id 3dr9j9958p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Jan 2022 02:17:29 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 20Q2HQ4U36897112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jan 2022 02:17:26 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3BCE642042; Wed, 26 Jan 2022 02:17:26 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 928F44203F; Wed, 26 Jan 2022 02:17:24 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.147.170]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 26 Jan 2022 02:17:24 +0000 (GMT) Subject: PING^2 [PATCH] rs6000: Don't turn off VSX for P9 VECTOR when TARGET_AVOID_XFORM set To: GCC Patches Cc: Michael Meissner , Bill Schmidt , Segher Boessenkool , David Edelsohn References: <8552a3a2-60ff-dd2d-1053-e2a4d5e72af3@linux.ibm.com> <2334efc1-10a6-eae8-c92c-68bee174ace1@linux.ibm.com> From: "Kewen.Lin" Message-ID: Date: Wed, 26 Jan 2022 10:17:23 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: <2334efc1-10a6-eae8-c92c-68bee174ace1@linux.ibm.com> Content-Type: text/plain; charset=gbk Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-GUID: mVKfwxfTazRtylc-t1dvATq8lryAbKTi X-Proofpoint-ORIG-GUID: lbh3xBhpuBjLe0rD5s2yMyqZ13GCjFPl Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-25_06,2022-01-25_02,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201260006 X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, MIME_CHARSET_FARAWAY, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 02:17:33 -0000 Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/587449.html BR, Kewen > on 2021/12/29 ÏÂÎç5:36, Kewen.Lin via Gcc-patches wrote: >> Hi, >> >> When TARGET_AVOID_XFORM is set, we turn off VSX. But at least from >> ISA3.0 (Power9), we support DQ form vector load/store. This patch >> is to make it not clear VSX when P9 VECTOR supported, it also checks >> some flags which P9 VECTOR relies on, otherwise those flags could >> disable P9 VECTOR later. >> >> Bootstrapped and regtested on powerpc64le-linux-gnu P9 and >> powerpc64-linux-gnu P8. >> >> Is it ok for trunk? >> >> BR, >> Kewen >> ----- >> gcc/ChangeLog: >> >> * config/rs6000/rs6000.c (rs6000_option_override_internal): Consider >> P9 VECTOR when determining to disable VSX for TARGET_AVOID_XFORM. >> --- >> gcc/config/rs6000/rs6000.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c >> index 66b01e589b0..c020947abc8 100644 >> --- a/gcc/config/rs6000/rs6000.c >> +++ b/gcc/config/rs6000/rs6000.c >> @@ -3865,7 +3865,10 @@ rs6000_option_override_internal (bool global_init_p) >> rs6000_isa_flags_explicit |= OPTION_MASK_VSX; >> } >> } >> - else if (TARGET_AVOID_XFORM > 0) >> + else if (TARGET_AVOID_XFORM > 0 >> + /* Exclude P9 VECTOR which supports DQ form, but need to check >> + some flags which are able to disable it as well. */ >> + && !(TARGET_ALTIVEC && TARGET_P8_VECTOR && TARGET_P9_VECTOR)) >> msg = N_("%<-mvsx%> needs indexed addressing"); >> else if (!TARGET_ALTIVEC && (rs6000_isa_flags_explicit >> & OPTION_MASK_ALTIVEC)) >> -- >> 2.27.0 >> >