From: Sandra Loosemore <sandra@codesourcery.com>
To: Tobias Burnus <tobias@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
Thomas Koenig <tkoenig@netcologne.de>
Cc: "José Rui Faustino de Sousa" <jrfsousa@gmail.com>
Subject: Re: [PATCH v3, Fortran] TS 29113 testsuite
Date: Thu, 19 Aug 2021 11:28:44 -0600 [thread overview]
Message-ID: <b8180d68-7a04-b963-0c4a-5789bd307b98@codesourcery.com> (raw)
In-Reply-To: <47e5cae8-1d71-4017-0978-96670a773ad0@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 3355 bytes --]
On 7/27/21 5:07 AM, Tobias Burnus wrote:
> Hi Sandra, hi Thomas, hi all,
>
> @Thomas K: Comments about the following - and of course to the
> testsuite itself - are highly welcome.
>
> In my opinion, the testsuite LGTM and can be committed.
>
> @Sandra:
> - Thoughts on the directory name? (cf. below)
> - Give others/Thomas a chance to comment on this,
> before committing it. (And remove the now passing xfails.)
> Thanks for the testsuite!
>
> Regarding:
>
> * XFAILS - as discussed before, I think having some XFAILS is
> not ideal but fine, especially if the XFAIL/PASS ratio is low
> and there are plans to fix the known fails, some posted patches
> for those, and open PRs for the issues.
>
> (I think there is one patch pending review and two patches pending
> committal with some modifications by Sandra - plus several patches
> by José which still need to be reviewed.)
>
>
> * Naming of the directory + .exp file:
> ts29113/ts29113.exp
> is okay. Given that 'select rank' (in F2018 but not in TS29113)
> is also tested, there was some controversy regarding the name
> and the coverage; additionally, TS29113 is a name which is not
> immediately clear. Thus, we could use some other name like:
> c-interop/c-interop.exp
> or .... (suggestions?).
> In any case, I do not feel strong about either name.
>
> * I had a closer look at earlier versions of the testsuite, I did
> browse through the current one + looked at the diff to previous
> version, but it is big enough and the spec is complex enough that
> I have likely missed something.
> Thus: Additional reviews are highly welcome!
Here is the current version of the testsuite. Changes since the last
version include:
* Renaming the directory and .exp file from ts29113 -> c-interop per the
request above. There have been no additional review comments.
* I also made it explicit that section and constraint numbers mentioned
in comments in the test cases refer to TS 29113. I considered using the
numbering from 2018 standard, but given that the standard already
renumbered things twice since the time TS 29113 was published I didn't
really see the point, as long as it is unambiguous what document is
being cited.
* I flattened the subdirectory structure after realizing that
dg-additional-sources can't cope with relative pathnames in remote-host
testing.
* I split up the typecodes tests (for testing that descriptors
constructed by the front end match ISO_Fortran_binding.h) to allow for
finer-grained control over xfails and dg-require-effective-target, and
added a new effective target for Fortran C_FLOAT128 support. There are
also some additional things being tested now in this group.
The current xfails in the tests reflect the two patches I posted last
night that are still waiting for review:
https://gcc.gnu.org/pipermail/fortran/2021-August/056382.html
https://gcc.gnu.org/pipermail/fortran/2021-August/056383.html
I've been testing on x86 (both 32- and 64-bit) and powerpc64le-linux-gnu.
Given that Tobias already said the last version of the patch was OK, I'd
like to commit this soon, either at the same time I push the patches
above, or next week if there is some hold-up on them. If anybody wants
more time to review this first, let me know.
-Sandra
[-- Attachment #2: ts29113-aug19.patch.gz --]
[-- Type: application/gzip, Size: 55592 bytes --]
next prev parent reply other threads:[~2021-08-19 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 5:53 [WIP, " Sandra Loosemore
2021-07-07 3:40 ` [PATCH, " Sandra Loosemore
2021-07-25 19:47 ` [PATCH v2, " Sandra Loosemore
2021-07-27 11:07 ` Tobias Burnus
2021-08-19 17:28 ` Sandra Loosemore [this message]
2021-09-03 7:46 ` [PATCH v3, " Christophe Lyon
2021-09-03 9:14 ` Tobias Burnus
2021-09-03 17:18 ` Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8180d68-7a04-b963-0c4a-5789bd307b98@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jrfsousa@gmail.com \
--cc=tkoenig@netcologne.de \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).