From e58ebd111e7b3b8047fb93396c204bd703926802 Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Wed, 1 Feb 2023 11:46:18 -0500 Subject: [PATCH] Reset SCEV before removing unreachable globals. SCEV should be reset in VRP before trying to remove unreachable globals to avoid triggering issues with it's cache. PR tree-optimization/107570 gcc/ * tree-vrp.cc (remove_and_update_globals): Reset SCEV. gcc/testsuite/ gcc.dg/pr107570.c: New. --- gcc/testsuite/gcc.dg/pr107570.c | 25 +++++++++++++++++++++++++ gcc/tree-vrp.cc | 4 ++++ 2 files changed, 29 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/pr107570.c diff --git a/gcc/testsuite/gcc.dg/pr107570.c b/gcc/testsuite/gcc.dg/pr107570.c new file mode 100644 index 00000000000..ba5b535a867 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr107570.c @@ -0,0 +1,25 @@ +/* { dg-do compile } */ +/* { dg-options "-Os" } */ + +long int n; + +void +foo (int *p, int x) +{ + for (;;) + { + for (*p = 0; *p < 1; ++*p) + { + n += *p < 0; + if (n < x) + { + while (x < 1) + ++x; + + __builtin_unreachable (); + } + } + + p = &x; + } +} diff --git a/gcc/tree-vrp.cc b/gcc/tree-vrp.cc index 3c431760a16..95547e5419b 100644 --- a/gcc/tree-vrp.cc +++ b/gcc/tree-vrp.cc @@ -121,6 +121,10 @@ remove_unreachable::remove_and_update_globals (bool final_p) if (m_list.length () == 0) return false; + // Ensure the cache in SCEV has been cleared before processing + // globals to be removed. + scev_reset (); + bool change = false; tree name; unsigned i; -- 2.39.0