From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from butterfly.birch.relay.mailchannels.net (butterfly.birch.relay.mailchannels.net [23.83.209.27]) by sourceware.org (Postfix) with ESMTPS id 0544A3858D3C for ; Thu, 16 Dec 2021 02:17:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0544A3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 3CEA78618A5; Thu, 16 Dec 2021 02:17:22 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2EE65861B27; Thu, 16 Dec 2021 02:17:08 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.109.250.15 (trex/6.4.3); Thu, 16 Dec 2021 02:17:22 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Quick-Chief: 405f54516bb74eff_1639621041552_2498753557 X-MC-Loop-Signature: 1639621041552:810143150 X-MC-Ingress-Time: 1639621041552 Received: from [192.168.52.116] (unknown [223.185.62.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4JDwjV1Sn3z1Nq; Wed, 15 Dec 2021 18:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1639621023; bh=EsBAYhPpyhgyipsU5fw9nmTBngI=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=QxnEfwHeXRFB3JEll2HS7WKISuus97LDUx+BHPxbKBQUhjZMCH7wsoUGY4UyQD5U2 +wqgS90h9XX3iyB606jy0gcYWoeFsHDT4u3/8+F2DrlYBQuv/TCFFlKgydMdIa9wTV K1nIrbRpR9uqYO2ifhOG6J1J8SjSwu94YJUeU1xE= Message-ID: Date: Thu, 16 Dec 2021 07:46:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v4 2/6] __builtin_dynamic_object_size: Recognize builtin Content-Language: en-US To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211201142757.4086840-1-siddhesh@gotplt.org> <20211201142757.4086840-3-siddhesh@gotplt.org> <20211215152401.GK2646553@tucnak> From: Siddhesh Poyarekar In-Reply-To: <20211215152401.GK2646553@tucnak> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3031.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2021 02:17:27 -0000 On 12/15/21 20:54, Jakub Jelinek wrote: > On Wed, Dec 01, 2021 at 07:57:53PM +0530, Siddhesh Poyarekar wrote: >> Recognize the __builtin_dynamic_object_size builtin and add paths in the >> object size path to deal with it, but treat it like >> __builtin_object_size for now. Also add tests to provide the same >> testing coverage for the new builtin name. >> >> gcc/ChangeLog: >> >> * builtins.def (BUILT_IN_DYNAMIC_OBJECT_SIZE): New builtin. >> * tree-object-size.h: Move object size type bits enum from >> tree-object-size.c and add new value OST_DYNAMIC. >> * builtins.c (expand_builtin, fold_builtin_2): Handle it. >> (fold_builtin_object_size): Handle new builtin and adjust for >> change to compute_builtin_object_size. >> * tree-object-size.c: Include builtins.h. >> (compute_builtin_object_size): Adjust. >> (early_object_sizes_execute_one, >> dynamic_object_sizes_execute_one): New functions. >> (object_sizes_execute): Rename insert_min_max_p argument to >> early. Handle BUILT_IN_DYNAMIC_OBJECT_SIZE and call the new >> functions. >> doc/extend.texi (__builtin_dynamic_object_size): Document new >> builtin. >> >> gcc/testsuite/ChangeLog: >> >> * g++.dg/ext/builtin-dynamic-object-size1.C: New test. >> * g++.dg/ext/builtin-dynamic-object-size2.C: Likewise. >> * gcc.dg/builtin-dynamic-alloc-size.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-1.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-10.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-11.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-12.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-13.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-14.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-15.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-16.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-17.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-18.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-19.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-2.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-3.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-4.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-5.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-6.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-7.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-8.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-9.c: Likewise. >> * gcc.dg/builtin-object-size-16.c: Adjust to allow inclusion >> from builtin-dynamic-object-size-16.c. >> * gcc.dg/builtin-object-size-17.c: Likewise. > > Ok, thanks. > > Jakub > May I commit this and the first patch (with the added assert)? That will allow me to add _FORTIFY_SOURCE=3 support for gcc 12.1 into glibc right away. Thanks, Siddhesh