From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26901 invoked by alias); 10 Apr 2018 00:37:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26891 invoked by uid 89); 10 Apr 2018 00:37:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-15.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Six, silence, adjective, hear X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Apr 2018 00:37:50 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1f5hIC-0006IS-Ib from Sandra_Loosemore@mentor.com ; Mon, 09 Apr 2018 17:37:48 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 9 Apr 2018 17:37:46 -0700 Subject: Re: [doc patch] remove hyphen from side-effect To: Martin Sebor , Gcc Patch List References: <67f20d0e-954d-509e-83aa-314dd0f2ba29@gmail.com> From: Sandra Loosemore Message-ID: Date: Tue, 10 Apr 2018 00:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-SW-Source: 2018-04/txt/msg00426.txt.bz2 On 04/09/2018 05:58 PM, Martin Sebor wrote: > Ping:  I will go ahead and commit this patch sometime this > week unless I hear objections: > >   https://gcc.gnu.org/ml/gcc-patches/2018-04/msg00036.html This patch is mostly OK, except for these hunks: > Index: gcc/doc/invoke.texi > =================================================================== > --- gcc/doc/invoke.texi (revision 259017) > +++ gcc/doc/invoke.texi (working copy) > @@ -8710,7 +8710,7 @@ default at @option{-O} and higher. > @item -ftree-builtin-call-dce > @opindex ftree-builtin-call-dce > Perform conditional dead code elimination (DCE) for calls to built-in functions > -that may set @code{errno} but are otherwise side-effect free. This flag is > +that may set @code{errno} but are otherwise side effect free. This flag is > enabled by default at @option{-O2} and higher if @option{-Os} is not also > specified. > s/side-effect free/free of side effects/ > @@ -14229,7 +14229,7 @@ not overridden} will do. > This option is implicitly passed to the compiler for the second > compilation requested by @option{-fcompare-debug}, along with options to > silence warnings, and omitting other options that would cause > -side-effect compiler outputs to files or to the standard output. Dump > +side effect compiler outputs to files or to the standard output. Dump > files and preserved temporary files are renamed so as to contain the > @code{.gk} additional extension during the second compilation, to avoid > overwriting those generated by the first. This is impossible to parse either with or without the hyphen. How about rewriting the end of that sentence as ...that would cause the compiler to produce output to files or to standard output as a side effect. ?? > @@ -3496,7 +3496,7 @@ instructions. > @cindex RTL predecrement > @cindex RTL postdecrement > > -Six special side-effect expression codes appear as memory addresses. > +Six special side effect expression codes appear as memory addresses. > > @table @code > @findex pre_dec This should either remain hyphenated (adjective phrase immediately before the noun), or rewritten as something like Six special expression codes represent memory addresses with side effects. > Index: gcc/doc/tm.texi.in > =================================================================== > --- gcc/doc/tm.texi.in (revision 259017) > +++ gcc/doc/tm.texi.in (working copy) > @@ -3967,7 +3967,7 @@ pre-decrement, post-increment, or post-decrement a > @defmac HAVE_PRE_MODIFY_DISP > @defmacx HAVE_POST_MODIFY_DISP > A C expression that is nonzero if the machine supports pre- or > -post-address side-effect generation involving constants other than > +post-address side effect generation involving constants other than > the size of the memory operand. > @end defmac > > @@ -3974,7 +3974,7 @@ the size of the memory operand. > @defmac HAVE_PRE_MODIFY_REG > @defmacx HAVE_POST_MODIFY_REG > A C expression that is nonzero if the machine supports pre- or > -post-address side-effect generation involving a register displacement. > +post-address side effect generation involving a register displacement. > @end defmac > > @defmac CONSTANT_ADDRESS_P (@var{x}) I think both of these should also remain hyphenated (adjective phrase immediately before the modified noun). -Sandra