public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Carlini <paolo.carlini@oracle.com>
To: Jason Merrill <jason@redhat.com>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] Locations related grokdeclarator tweak
Date: Mon, 21 Jan 2019 17:38:00 -0000	[thread overview]
Message-ID: <b85569d9-6945-4614-a3cb-5091f8f77429@oracle.com> (raw)
In-Reply-To: <2e6fe4b4-3d4f-b5b8-9722-ca02bf8cf992@redhat.com>

Hi,

On 21/01/19 18:22, Jason Merrill wrote:
> On 1/18/19 6:13 AM, Paolo Carlini wrote:
>> a tweak to typespec_loc, where the existing conditional turns out to 
>> be just a special case of the full min_location that we want in order 
>> to do the right thing for testcases like diagnostic/trailing1.C. 
>> Tested x86_64-linux.
>
> This is OK, but I don't think we want to keep messing with diagnostic 
> locations now that we're in stage 4.  This isn't a regression fix, is it?

I agree, isn't a regression fix and probably we don't want to (further 
;) mess with locations in stage 4. In any case, I'm essentially done 
with most of the low hanging fruits, I continued for a while with what I 
had ready... Anyway, that said, what do you think, shall I schedule this 
one for next Stage 1?

Thanks! Paolo.

      reply	other threads:[~2019-01-21 17:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 11:13 Paolo Carlini
2019-01-21 17:22 ` Jason Merrill
2019-01-21 17:38   ` Paolo Carlini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b85569d9-6945-4614-a3cb-5091f8f77429@oracle.com \
    --to=paolo.carlini@oracle.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).