From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id BF7303858D20 for ; Fri, 3 Feb 2023 10:38:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF7303858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="diff'?scan'208";a="95535026" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 03 Feb 2023 02:38:45 -0800 IronPort-SDR: 0GpWSshfO6E4bS7PG81zSjwK3xz9fXcNDZM9PdTxopLK65HPOffAI36ZLmxOoL824HJX0jEfy7 p/c4SKvADofTW9EflHEfmLq/HX0o5oG7xjeblsn3tjYca15bZzCrIFUIihiRUmTw9lRG+3T4pL tGx0GJpfyd8khLtmrA7wDWgZ1oO5zSKOYw1jt+ZsIYiMBe+22e66RC62mm0YcUAVDJyow3HAP5 gTy71CcUIPzV4pC41xNrEixHuGLZ3bSHLL0Fu5IkghDA0+YJmMvGDfko4zPKk11BsDX1QCTAw7 Cw4= Content-Type: multipart/mixed; boundary="------------4kdNrjd11hguQpIN9tv6awef" Message-ID: Date: Fri, 3 Feb 2023 11:38:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Patch] libgomp: Fix reverse offload issues Content-Language: en-US From: Tobias Burnus To: gcc-patches , Jakub Jelinek References: <4c058f14-c719-b66a-f556-9bda3a4c4556@codesourcery.com> In-Reply-To: <4c058f14-c719-b66a-f556-9bda3a4c4556@codesourcery.com> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------4kdNrjd11hguQpIN9tv6awef Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Now committed as obvious as r13-5680-g0b1ce70a813b98ef2893779d14ad6c90c5d06a71. I improved the wording in the commit comment a bit, compared to previous attachment and I have verified that those features work with AMDGCN* and without offloading. Tobias (* it seems as if there is still another issue with mapping, this time for array-descriptor variables that do not exist on the host, i.e. that have to be fully mapped to the host. I will look into this today or Monday.= ) On 02.02.23 15:13, Tobias Burnus wrote: > Found when testing AMD GCN offloading, the second issue came up with > libgomp.fortran/reverse-offload-5.f90. (But oddly not with nvptx.) > > While the first one (new test: libgomp.fortran/reverse-offload-6.f90) > came up when debugging the issue. > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe > 201, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; > Gesch=C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der G= esellschaft: > M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------4kdNrjd11hguQpIN9tv6awef Content-Type: text/x-patch; charset="UTF-8"; name="committed.diff" Content-Disposition: attachment; filename="committed.diff" Content-Transfer-Encoding: base64 Y29tbWl0IDBiMWNlNzBhODEzYjk4ZWYyODkzNzc5ZDE0YWQ2YzkwYzVkMDZhNzEKQXV0aG9y OiBUb2JpYXMgQnVybnVzIDx0b2JpYXNAY29kZXNvdXJjZXJ5LmNvbT4KRGF0ZTogICBGcmkg RmViIDMgMTE6MzE6NTMgMjAyMyArMDEwMAoKICAgIGxpYmdvbXA6IEZpeCByZXZlcnNlIG9m ZmxvYWQgaXNzdWVzCiAgICAKICAgIElmIHRoZXJlIGlzIG5vdGhpbmcgdG8gbWFwLCBza2lw IHRoZSBtYXBwaW5nIGFuZCBhdm9pZCBhdHRlbXB0aW5nIHRvCiAgICBjb3B5IDAgYnl0ZXMg ZnJvbSBhZGRycywgc2l6ZXMgYW5kIGtpbmRzLgogICAgCiAgICBBZGRpdGlvbmFsbHksIGl0 IGNvdWxkIGhhcHBlbiB0aGF0IGEgbm9uLWFsbG9jYXRlZCBhZGRyZXNzIHdhcyBkZWFsbG9j YXRlZCwKICAgIHN1Y2ggYXMgYSBwb2ludGVyIHNldCwgbGVhZGluZyB0byBhIGZyZWUgZm9y IHRoZSBhY3R1YWwgZGF0YS4KICAgIAogICAgbGliZ29tcC8KICAgICAgICAgICAgKiB0YXJn ZXQuYyAoZ29tcF90YXJnZXRfcmV2KTogSGFuZGxlIG1hcG51bSA9PSAwIGFuZCBhdm9pZAog ICAgICAgICAgICBmcmVlaW5nIG5vdCBhbGxvY2F0ZWQgbWVtb3J5LgogICAgICAgICAgICAq IHRlc3RzdWl0ZS9saWJnb21wLmZvcnRyYW4vcmV2ZXJzZS1vZmZsb2FkLTYuZjkwOiBOZXcg dGVzdC4KLS0tCiBsaWJnb21wL3RhcmdldC5jICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICA4ICsrKy0tLQogLi4uL2xpYmdvbXAuZm9ydHJhbi9yZXZlcnNlLW9mZmxv YWQtNi5mOTAgICAgICAgICAgfCAzMiArKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVz IGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvbGliZ29tcC90YXJnZXQuYyBiL2xpYmdvbXAvdGFyZ2V0LmMKaW5kZXggYjE2ZWU3NjFh OTUuLmMxNjgyY2FlYTEzIDEwMDY0NAotLS0gYS9saWJnb21wL3RhcmdldC5jCisrKyBiL2xp YmdvbXAvdGFyZ2V0LmMKQEAgLTMzMjQsNyArMzMyNCw3IEBAIGdvbXBfdGFyZ2V0X3JldiAo dWludDY0X3QgZm5fcHRyLCB1aW50NjRfdCBtYXBudW0sIHVpbnQ2NF90IGRldmFkZHJzX3B0 ciwKICAgICBnb21wX2ZhdGFsICgiQ2Fubm90IGZpbmQgcmV2ZXJzZS1vZmZsb2FkIGZ1bmN0 aW9uIik7CiAgIHZvaWQgKCpob3N0X2ZuKSgpID0gKHZvaWQgKCopKCkpIG4tPmstPmhvc3Rf c3RhcnQ7CiAKLSAgaWYgKGRldmljZXAtPmNhcGFiaWxpdGllcyAmIEdPTVBfT0ZGTE9BRF9D QVBfU0hBUkVEX01FTSkKKyAgaWYgKChkZXZpY2VwLT5jYXBhYmlsaXRpZXMgJiBHT01QX09G RkxPQURfQ0FQX1NIQVJFRF9NRU0pIHx8IG1hcG51bSA9PSAwKQogICAgIHsKICAgICAgIGRl dmFkZHJzID0gKHVpbnQ2NF90ICopICh1aW50cHRyX3QpIGRldmFkZHJzX3B0cjsKICAgICAg IHNpemVzID0gKHVpbnQ2NF90ICopICh1aW50cHRyX3QpIHNpemVzX3B0cjsKQEAgLTM0MDIs NyArMzQwMiw3IEBAIGdvbXBfdGFyZ2V0X3JldiAodWludDY0X3QgZm5fcHRyLCB1aW50NjRf dCBtYXBudW0sIHVpbnQ2NF90IGRldmFkZHJzX3B0ciwKIAkgIH0KICAgICB9CiAKLSAgaWYg KCEoZGV2aWNlcC0+Y2FwYWJpbGl0aWVzICYgR09NUF9PRkZMT0FEX0NBUF9TSEFSRURfTUVN KSkKKyAgaWYgKCEoZGV2aWNlcC0+Y2FwYWJpbGl0aWVzICYgR09NUF9PRkZMT0FEX0NBUF9T SEFSRURfTUVNKSAmJiBtYXBudW0gPiAwKQogICAgIHsKICAgICAgIHNpemVfdCBqLCBzdHJ1 Y3RfY3B5ID0gMDsKICAgICAgIHNwbGF5X3RyZWVfa2V5IG4yOwpAQCAtMzYzOCw3ICszNjM4 LDcgQEAgZ29tcF90YXJnZXRfcmV2ICh1aW50NjRfdCBmbl9wdHIsIHVpbnQ2NF90IG1hcG51 bSwgdWludDY0X3QgZGV2YWRkcnNfcHRyLAogCiAgIGhvc3RfZm4gKGRldmFkZHJzKTsKIAot ICBpZiAoIShkZXZpY2VwLT5jYXBhYmlsaXRpZXMgJiBHT01QX09GRkxPQURfQ0FQX1NIQVJF RF9NRU0pKQorICBpZiAoIShkZXZpY2VwLT5jYXBhYmlsaXRpZXMgJiBHT01QX09GRkxPQURf Q0FQX1NIQVJFRF9NRU0pICYmIG1hcG51bSA+IDApCiAgICAgewogICAgICAgdWludDY0X3Qg c3RydWN0X2NweSA9IDA7CiAgICAgICBib29sIGNsZWFuX3N0cnVjdCA9IGZhbHNlOwpAQCAt MzY4MCw3ICszNjgwLDcgQEAgZ29tcF90YXJnZXRfcmV2ICh1aW50NjRfdCBmbl9wdHIsIHVp bnQ2NF90IG1hcG51bSwgdWludDY0X3QgZGV2YWRkcnNfcHRyLAogCSAgICAgIGNsZWFuX3N0 cnVjdCA9IHRydWU7CiAJICAgICAgc3RydWN0X2NweSA9IHNpemVzW2ldOwogCSAgICB9Ci0J ICBlbHNlIGlmIChjZGF0YVtpXS5hbGlnbmVkKQorCSAgZWxzZSBpZiAoIWNkYXRhW2ldLnBy ZXNlbnQgJiYgY2RhdGFbaV0uYWxpZ25lZCkKIAkgICAgZ29tcF9hbGlnbmVkX2ZyZWUgKCh2 b2lkICopICh1aW50cHRyX3QpIGRldmFkZHJzW2ldKTsKIAkgIGVsc2UgaWYgKCFjZGF0YVtp XS5wcmVzZW50KQogCSAgICBmcmVlICgodm9pZCAqKSAodWludHB0cl90KSBkZXZhZGRyc1tp XSk7CmRpZmYgLS1naXQgYS9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmZvcnRyYW4vcmV2 ZXJzZS1vZmZsb2FkLTYuZjkwIGIvbGliZ29tcC90ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFu L3JldmVyc2Utb2ZmbG9hZC02LmY5MApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMC4uMDQ4NjZlZGJiYTcKLS0tIC9kZXYvbnVsbAorKysgYi9saWJnb21wL3Rlc3Rz dWl0ZS9saWJnb21wLmZvcnRyYW4vcmV2ZXJzZS1vZmZsb2FkLTYuZjkwCkBAIC0wLDAgKzEs MzIgQEAKKyEKKyEgRW5zdXJlIHRoYXQgYSBtYXBwaW5nIHdpdGggbm8gYXJndW1lbnQgd29y a3MKKyEKKworbW9kdWxlIG0KKyAgaW1wbGljaXQgbm9uZSAodHlwZSwgZXh0ZXJuYWwpCisg IGludGVnZXIgOjogeCA9IDMyCisgIGludGVnZXIgOjogZGV2X251bTIgPSAtMQorY29udGFp bnMKK3N1YnJvdXRpbmUgIGZvbygpCisgIHVzZSBvbXBfbGliLCBvbmx5OiBvbXBfZ2V0X2Rl dmljZV9udW0KKyAgeCA9IHggKyAxMAorICBkZXZfbnVtMiA9IG9tcF9nZXRfZGV2aWNlX251 bSgpCitlbmQKK2VuZCBtb2R1bGUgbQorCit1c2UgbQordXNlIG9tcF9saWIKKyEkb21wIHJl cXVpcmVzIHJldmVyc2Vfb2ZmbG9hZAoraW1wbGljaXQgbm9uZSAodHlwZSwgZXh0ZXJuYWwp CitpbnRlZ2VyIDo6IGRldl9udW0gPSAtMQorISRvbXAgdGFyZ2V0IG1hcChmcm9tOmRldl9u dW0pCisgIGRldl9udW0gPSBvbXBfZ2V0X2RldmljZV9udW0oKQorICAhIFRoaXMgY2FsbHMg R09NUF90YXJnZXRfZXh0IHdpdGggbnVtYmVyIG9mIG1hcHMgPSAwCisgICEkb21wIHRhcmdl dCBkZXZpY2UoYW5jZXN0b3I6MSkKKyAgICBjYWxsIGZvbworICAhJG9tcCBlbmQgdGFyZ2V0 CishJG9tcCBlbmQgdGFyZ2V0CisKK2lmIChvbXBfZ2V0X251bV9kZXZpY2VzKCkgPiAwIC5h bmQuICBkZXZfbnVtMiA9PSBkZXZfbnVtKSBzdG9wIDEKK2lmICh4IC89IDQyKSBzdG9wIDIK K2VuZAo= --------------4kdNrjd11hguQpIN9tv6awef--