From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 7B65D386102B for ; Wed, 5 May 2021 17:05:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7B65D386102B Received: by mail-pl1-x62f.google.com with SMTP id v20so1434471plo.10 for ; Wed, 05 May 2021 10:05:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ojux33fu1IrkR5W83v27Aa7AHAoEXziXEqrKSnbLI3A=; b=nNhPWNHhAHEeS7m1uPbh6C594Auc5ugCRjIYFc0zvq9qZXvEEZ8jIE6mpAkVIpikml Qs1UoaacJdKQPKiYQbpZ/5+Fq8qfVDsm++IPXmElo2NHOZNbVwi+fua9ZHupTLWlBck6 wdHacEL1W/lyQ6yyMIvT3K/FKYkF6XjdFEBmCTE8Ecbh0TYj0WP8NifvdQYp53vhksRK Ozpj1uN0mRY9SDhtBPBXLbmXzBhxfTU9gnZHBelCJXn2XLB1N20Dn/e8omubnNlHsuDS +W1b1oOMPOSQTu/jnvkYpINgaiRypKBsZajShRbaXs07Ru9AQPv3O18dYhOIJ8YCCZXX 9Tkw== X-Gm-Message-State: AOAM530aL06Y2Eg1oWcXh80/S6QAa6FF5jpw50UlqoS1W34adJO9Cq65 0L4fWlmt1QpiC9l6HE8kmeOzDNIY+d/heQ== X-Google-Smtp-Source: ABdhPJwdsBsMNDo298nAIAsxEs0WOFvuc+Ec+np2pSLzE3KgrFopE9RN4nKG1bkJipBUcPC32t5YQQ== X-Received: by 2002:a17:902:b408:b029:ec:e879:bbd8 with SMTP id x8-20020a170902b408b02900ece879bbd8mr32973957plr.65.1620234317345; Wed, 05 May 2021 10:05:17 -0700 (PDT) Received: from [192.168.1.2] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id g1sm6917351pgi.64.2021.05.05.10.05.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 May 2021 10:05:16 -0700 (PDT) Subject: Re: [PATCH] testsuite: Add vect_floatint_cvt to gcc.dg/vect/pr56541.c To: Robin Dapp , GCC Patches References: From: Jeff Law Message-ID: Date: Wed, 5 May 2021 11:05:16 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2021 17:05:19 -0000 On 5/5/2021 8:31 AM, Robin Dapp via Gcc-patches wrote: > Hi, > > pr56541.c implicitly converts a float vector to an int (bool) vector: > >  rMin = (rMax>0) ? rMin : rBig; > > It fails on some s390 targets because the do not support converting > from vector float to int.  Is adding a vect_floatint_cvt as in the > attached patch the OK thing to do? > > Or better an xfail with ! vect_floatint_cvt? > > Regards >  Robin > > gcc/testsuite/ChangeLog: > >         * gcc.dg/vect/pr56541.c: Add vect_floatint_cvt. OK.  I'd tend to use XFAIL for a compiler bug that we haven't fixed.  In this case the target doesn't support what the test is trying to do.  So skipping the test in one manner or another seems better. jeff