From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 3070C3855598 for ; Thu, 26 Oct 2023 08:41:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3070C3855598 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3070C3855598 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698309707; cv=none; b=llGiYfuxsxtDkYDlZtfDc+C+ZFiE3TRSMfzvTnoFqvezQLcHFSPfMx1r5qjeUY2Och9NmB5dOPGZV7i6c3nfSpS3DWWiPHTLAjphx5WiPihCU4w8AUc+IL457+qP07d9D2WNAcADseTYkLMyVk8+YT5UbepG1FWzYVsrh/Wr1jk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698309707; c=relaxed/simple; bh=Q7OA+ilFTCXhDdm1sw7nncgHjyuIwNdMBxpzHGrcYKY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EMszFI0dcPYN4pwLbiihp1ScDHwbL+3kIl9zklZOeI5alak7IxkLtCNohQOOAzbxYbzpzMdQeWlg+kDMcN2UCG3KRwevXTpg1dtXxurxZbrjWY8yIST/m9GzXvBdORki/MfKj0fM6DlDVZSPtdjmS6diyJKbzHIH6ozzR1EDHGs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40842752c6eso5098365e9.1 for ; Thu, 26 Oct 2023 01:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698309705; x=1698914505; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/rkoLK0925Ecle2ErMkwGASTnTvhuJ/1HJKxOhy3o9U=; b=hgJ6vou98ktazsjNwIBrkp0OmeCEARrZS9BuQyqYTeVQJaFtoPzWsjn/rf3jWXn9Vw r4zognKrVhNOxPeCfF1RmmbVDQ+xuHvmUUU2Y6aP+IDgEuWOFresZBWubNpizDFduAPB Mbf0HbxeKdwo5UzAeh2CI6+2kS0aTdvLItIcOdqky+kXjGv+Cfj+ZUSV1ElDf+HWyLOm sddDEhNNXO+cC7c7JCBt/trwPJlpqlwiCQwi3LSijXHpIK7iYBh8cfioKLrUnh7wOvqy U/0imy/t68ddk3E1dSagbiwAe7qPkGdTeE8K9CuXiXIoRCEz0MXhQTEBYtG4fSL85icx R4dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698309705; x=1698914505; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/rkoLK0925Ecle2ErMkwGASTnTvhuJ/1HJKxOhy3o9U=; b=c6qpQLVbO3xWX+aFiUPqpHUar972hdu5ucVktj0fL1J283xleEd/C8lpVKNWkntxsD uLnPhM41eil2Emlgh44E9cIr8euOao2PatrCGFouAHZV2hgyh24OPtOGb1bTKytlbmg3 WmEKI3HpQWRYrlM9CqX5Urv3dyvX9MLFAhJTFbsjWkn/Hq5ciIp13gtvTqIUyvFwT9fh eecsqH113eqVLizEUaqpN416eh9oUszl8LAf5tBYrUD+vtSdo0IJoMChUZ8ozGFMUV8Q bPVIARnb31N0/be9ifidPjIVPCr3MGeVoPsuRCiLhSS44bmIm8WCoPVaRet8VjNOGv90 Tldg== X-Gm-Message-State: AOJu0YxVso4DYQ7O9rebhvRRsaovPObls++j9ow4udkStz7JT2hK2ulm CVkd4laE1M18mp3o6KGow2o= X-Google-Smtp-Source: AGHT+IEvin1GMHgGosY3rPz8IN+eiTF3eLrjKTVUkB1/liDP83Fm3Itt3589fW8Q64oALWrdceAh2w== X-Received: by 2002:a05:600c:1385:b0:405:348e:aa43 with SMTP id u5-20020a05600c138500b00405348eaa43mr14750204wmf.12.1698309704533; Thu, 26 Oct 2023 01:41:44 -0700 (PDT) Received: from [192.168.1.23] (ip-046-223-203-173.um13.pools.vodafone-ip.de. [46.223.203.173]) by smtp.gmail.com with ESMTPSA id l7-20020a05600c4f0700b00407752bd834sm1967044wmq.1.2023.10.26.01.41.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 01:41:44 -0700 (PDT) Message-ID: Date: Thu, 26 Oct 2023 10:41:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, gcc-patches , rguenther Subject: Re: [PATCH] internal-fn: Add VCOND_MASK_LEN. To: =?UTF-8?B?6ZKf5bGF5ZOy?= , "richard.sandiford" References: Content-Language: en-US From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Yeah. I think Robin may need this : > > TREE_CODE (else_val) == SSA_NAAME > && SSA_NAME_IS_DEFAULT_DEF (else_val) > && VAR_P (SSA_NAME_VAR (else_val)) > > to differentiate whether the ELSE VALUE is uninitialized SSA or not. I think we are talking about a different simplification now. This one we could still add as a match.pd pattern simplifying every conditional operation with an undefined else value. I just re-checked - without my pattern that turns VCOND_MASK_LEN into VEC_COND there is only one additional fail. (cond_widen_reduc-2.c where we scan for vfwreduc). I guess I can just change the combine pattern to combine cond as well as length masking (merge + if_then_else) when the else value is similar in both. Then we would avoid my dubious simplification and still get rid of the execution failures. Surely Richard is right in that we cannot "unconditionally" fold away the length but my naive hunch is that we currently never create situations where this really leads to errors. Regards Robin