On 8/1/19 4:41 PM, Jakub Jelinek wrote:
> On Thu, Aug 01, 2019 at 04:34:09PM +0200, Martin Liška wrote:
>> Ok, after deeper discussion with Honza, I would like to suggest the original
>> patch that was about proper detection of jobserver.
>>
>> Can you please Jakub test the patch in your environment?
> 
> Isn't this done too late (as in, doesn't the driver at that moment already
> have some files newly openend, like e.g. the @ option files?

You are right, I've reworked that. Good observation.

> 
>> +		= ((sscanf (n, "--jobserver-auth=%d,%d", &rfd, &wfd) == 2)
> 
> No need to wrap sscanf (...) == 2 into ()s.  Also, you've already done
> a strstr, what is the point in verifying it once again that it starts with
> --jobserver-auth= string?
> And in the lto-writer.c code there is no space between sscanf and (.

Yep, I simplified that.

Martin

> 
> 	Jakub
>