public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Add OPTIONS_H_EXTRA to GTFILES
@ 2022-09-28  6:35 Richard Sandiford
  2022-09-28 17:26 ` Jeff Law
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Sandiford @ 2022-09-28  6:35 UTC (permalink / raw)
  To: gcc-patches

I have a patch that adds a typedef to aarch64's <cpu>-opts.h.
The typedef is used for a TargetVariable in the .opt file,
which means that it is covered by PCH and so needs to be
visible to gengtype.

<cpu>-opts.h is not included directly in tm.h, but indirectly
by target headers (in this case aarch64.h).  There was therefore
nothing that caused it to be added to GTFILES.

Tested on aarch64-linux-gnu and x86_64-linux-gnu.  OK to install?

Richard


gcc/
	* Makefile.in (GTFILES): Add OPTIONS_H_EXTRA.
---
 gcc/Makefile.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 59b67d99441..c1d04384399 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2661,6 +2661,7 @@ s-match: build/genmatch$(build_exeext) $(srcdir)/match.pd cfn-operators.pd
 
 GTFILES = $(CPPLIB_H) $(srcdir)/input.h $(srcdir)/coretypes.h \
   $(host_xm_file_list) \
+  $(OPTIONS_H_EXTRA) \
   $(tm_file_list) $(HASHTAB_H) $(SPLAY_TREE_H) $(srcdir)/bitmap.h \
   $(srcdir)/wide-int.h $(srcdir)/alias.h \
   $(srcdir)/coverage.cc  $(srcdir)/rtl.h \
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add OPTIONS_H_EXTRA to GTFILES
  2022-09-28  6:35 [PATCH] Add OPTIONS_H_EXTRA to GTFILES Richard Sandiford
@ 2022-09-28 17:26 ` Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2022-09-28 17:26 UTC (permalink / raw)
  To: gcc-patches


On 9/28/22 00:35, Richard Sandiford via Gcc-patches wrote:
> I have a patch that adds a typedef to aarch64's <cpu>-opts.h.
> The typedef is used for a TargetVariable in the .opt file,
> which means that it is covered by PCH and so needs to be
> visible to gengtype.
>
> <cpu>-opts.h is not included directly in tm.h, but indirectly
> by target headers (in this case aarch64.h).  There was therefore
> nothing that caused it to be added to GTFILES.
>
> Tested on aarch64-linux-gnu and x86_64-linux-gnu.  OK to install?
>
> Richard
>
>
> gcc/
> 	* Makefile.in (GTFILES): Add OPTIONS_H_EXTRA.

OK

jeff



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-28 17:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28  6:35 [PATCH] Add OPTIONS_H_EXTRA to GTFILES Richard Sandiford
2022-09-28 17:26 ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).