From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 55A9F3882AEC for ; Wed, 19 Jun 2024 03:03:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55A9F3882AEC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 55A9F3882AEC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718766205; cv=none; b=eUstUeYpIHHWd7NYsdFOD4IdLM6Lghp6Q/cMNXQTGPoatVBqTCkQmVFsI6ri9O/+h6IkwXgoSk4IW716mW3LUR00pyz+55Jp3KfMK1n2l1ggnnHH3dLQiDusEM1DOC0hjvMJRk/8eeTxqnqxJairYJ92NFPstunmgpDjw1M42/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718766205; c=relaxed/simple; bh=/HggLKK3NVlgvCEnzoxEPMDnkIeEceVkLJl9KiqZ984=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=HYNR/7QY29rZ88g33ZLKeDxPYUTL3/K1oLYQw/d40JrbkuXHTNmhdJ7z7fGJEJ3zzGplTLyKez0aDyuRhj91lq6stooROkWmjsHMuctZ8gdWj8u9diPa/lORPawTp29FOo+7MEkpWiZinTx+2b2uIjSa0u5vZ4IRxPLgHTzVGZo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45J2QdN8022963; Wed, 19 Jun 2024 03:03:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:references:cc:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=J hd7drpgwgw4Cfs3Q8As+6u+hbJAQr4gtJRvfnw9m5c=; b=hfYdAiFgXQu01R90T UH4SeYkCae/ZG5fbrt/5JUUBa6PjlXiqSeUwzzpL9lUAPZJ6KPOKBRoO9Z2z4QSC JmXBApstNL1Gb/Y6nAy1ERLKjSpzeM5pYtVT1odYJfwkyFb1wtOI/ZVLOuYdyHyK WDK+lSlJu9LJ0djXO5wmdHBA/l6ZqxoFuq/ezyekiwcQMcUEWBmjr9V8o8nqSGqu vk60/tL/5hu9NDM5wqk0zsMD+sWRl4m6OBoI15d7HXKzKRzxyP1A92hjDFNbsyP6 3B7TGcvJQ2IX02uq5a59KHNMvAgwpsHbTwtdn3vMAW3N3AgD+IMr5qd8Ze4gxoZ4 YRJQA== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yup2wr3a4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 03:03:23 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45J0dZBC011442; Wed, 19 Jun 2024 03:03:23 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yspsn8euh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 03:03:22 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45J33HE032965026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2024 03:03:19 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F312020043; Wed, 19 Jun 2024 03:03:16 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 988F92004F; Wed, 19 Jun 2024 03:03:15 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 19 Jun 2024 03:03:15 +0000 (GMT) Message-ID: Date: Wed, 19 Jun 2024 11:03:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/13 ver4] rs6000, Remove __builtin_vsx_xvcvspsxws,, __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws built-ins. Content-Language: en-US To: Carl Love References: <073e4ca4-be47-4037-8719-035c4781b1a9@linux.ibm.com> <4e3c59b0-b6d9-4b29-a65f-c877926a4552@linux.ibm.com> Cc: gcc-patches@gcc.gnu.org, Segher Boessenkool , "bergner@linux.ibm.com" From: "Kewen.Lin" In-Reply-To: <4e3c59b0-b6d9-4b29-a65f-c877926a4552@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 70HJ65nohvaVRSwjxykKAjXRI4WeleRa X-Proofpoint-ORIG-GUID: 70HJ65nohvaVRSwjxykKAjXRI4WeleRa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-18_08,2024-06-17_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 clxscore=1015 adultscore=0 malwarescore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406190021 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Carl, on 2024/6/14 03:40, Carl Love wrote: > GCC maintainers: > > Per the comments on patch 0004 from version 3, the removal of > The built-in __builtin_vsx_xvcvdpuxds_uns and __builtin_vsx_xvcvspuxws was moved to this patch. The rest of the patch is unchanged from version 3. There were no comments on this patch for version 3. > > Please let me know if this patch is acceptable. Thanks. > > Carl > > > ----------------------------------------------------- > > rs6000, Remove __builtin_vsx_xvcvspsxws, > __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws built-ins. Nit: Maybe make it shorter like: Remove built-ins __builtin_vsx_xvcv{sp{sx,u}ws,dpuxds_uns} > > The built-in __builtin_vsx_xvcvspsxws is a duplicate of the vec_signed Nit: Strictly speaking, not a duplicate of vec_signed but covered by it. > built-in that is documented in the PVIPR. The __builtin_vsx_xvcvspsxws > built-in is not documented and there are no test cases for it. > > The built-in __builtin_vsx_xvcvdpuxds_uns is redundant as it is covered by > vec_unsigned, remove. > > The __builtin_vsx_xvcvspuxws is redundant as it is covered by > vec_unsigned, remove. As mentioned in the previous review, I'd expect patch 4/13 only focuses on extending vec_{un,}signed{e,o} for vector float (aka. __builtin_vsx_xvcvspsxds and __builtin_vsx_xvcvspuxds related), and this patch focuses on some built-in removals which have been covered by the existing vec_{un,}signed{,e,o}, so it can also drop the built-ins: "The built-in __builtin_vsx_xvcvdpsxws is redundant as it is covered by vec_signed{e,o}, remove. The built-in __builtin_vsx_xvcvdpuxws is redundant as it is covered by vec_unsigned{e,o}, remove." // copied from 4/13. BR, Kewen > > This patch removes the redundant built-in. > > gcc/ChangeLog: > * config/rs6000/rs6000-builtins.def (__builtin_vsx_xvcvspsxws, > __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws): > Remove built-in definitions. > --- > gcc/config/rs6000/rs6000-builtins.def | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def > index 7c36976a089..8cf0b715898 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -1697,9 +1697,6 @@ > const vsll __builtin_vsx_xvcvdpuxds_scale (vd, const int); > XVCVDPUXDS_SCALE vsx_xvcvdpuxds_scale {} > > - const vull __builtin_vsx_xvcvdpuxds_uns (vd); > - XVCVDPUXDS_UNS vsx_fixuns_truncv2dfv2di2 {} > - > const vsi __builtin_vsx_xvcvdpuxws (vd); > XVCVDPUXWS vsx_xvcvdpuxws {} > > @@ -1709,15 +1706,9 @@ > const vsll __builtin_vsx_xvcvspsxds (vf); > XVCVSPSXDS vsx_xvcvspsxds {} > > - const vsi __builtin_vsx_xvcvspsxws (vf); > - XVCVSPSXWS vsx_fix_truncv4sfv4si2 {} > - > const vsll __builtin_vsx_xvcvspuxds (vf); > XVCVSPUXDS vsx_xvcvspuxds {} > > - const vsi __builtin_vsx_xvcvspuxws (vf); > - XVCVSPUXWS vsx_fixuns_truncv4sfv4si2 {} > - > const vd __builtin_vsx_xvcvsxddp (vsll); > XVCVSXDDP vsx_floatv2div2df2 {} >