From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cmx-torrgo002.bell.net (mta-tor-001.bell.net [209.71.212.28]) by sourceware.org (Postfix) with ESMTP id D956A3861876 for ; Thu, 16 Nov 2023 22:33:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D956A3861876 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bell.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bell.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D956A3861876 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.71.212.28 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700174015; cv=none; b=NO0MCvennH7Vyk3VFTwJBsHb2kP+fjQQHUy0S3A1wLq63YaeE+gC/VPis2m7VJCCFpHhpoMHjbN1BQU4EOGlmK8OdF5iMUtillHLpIQg26n9q1QB/mnIzOVoOIu6hGogLfiBM0gNvJqbbm/BoXDEXjjFFh/HWwAzZXA9W0SdSb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700174015; c=relaxed/simple; bh=CbBbk95jWMYSFqBSheI0mRcAC2XQX9LrP1teXlSFHTI=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=W1RDc7NrsDA7dohYfasbpyK/Z2BOC81x1/L5PTPxkT8CBbeESrGXXKV1q1zn64AbHTLIOTkkEIBAD5gjKJOF8FJDsxu1K8rDaw1iqhobfSM+KkbHTieWG6Z7KDGAyomVdDhEBJbsbSJzdY4w7ElK5EGxAElXYwlVkLi5mWQmGbE= ARC-Authentication-Results: i=1; server2.sourceware.org X-RG-CM-BuS: 0 X-RG-CM-SC: 0 X-RG-CM: Clean X-Originating-IP: [142.126.114.79] X-RG-Env-Sender: dave.anglin@bell.net X-RG-Rigid: 655336270041B579 X-CM-Envelope: MS4xfL6OVPIcUdVlAjMxeUsLsNXv21R0yxPUdiyWi10LqnT1BkohQ0Huu39EILh8s7ttkIbD7TpZp/DIULS5x3hqa9j+Vc551fCMx2LuFaAM87sJLZSIKApe 4mXxmO1ccQoUTeajZKgr2dJJbPXR/rVy8Fxr0/q2Vl1PIZgDOD75uTLESkWaH8zWF31+5yhx+g6YMa4WW3dWndmUAibAalaAUXFni3QnGnJ2QeAneCZr8DPY OQaZGgrpJ9JLs4DXRPA426r2mnk7ytTZwmrmiRZ5rEnTyzm8QN8OAu1ai7E2VJLw8gs4XEzDwoskvA0Occ3DKlCSSkMPcE+4zxuFXbU0BqA= X-CM-Analysis: v=2.4 cv=A7QPg4aG c=1 sm=1 tr=0 ts=655698ae a=qwLmA0wx3TwW38sY+xTbUA==:117 a=qwLmA0wx3TwW38sY+xTbUA==:17 a=IkcTkHD0fZMA:10 a=mDV3o1hIAAAA:8 a=FBHGMhGWAAAA:8 a=Qc9de_8Biqf-opIMAkQA:9 a=QEXdDO2ut3YA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=9gvnlMMaQFpL9xblJ6ne:22 Received: from [192.168.2.49] (142.126.114.79) by cmx-torrgo002.bell.net (5.8.814) (authenticated as dave.anglin@bell.net) id 655336270041B579; Thu, 16 Nov 2023 17:33:18 -0500 Message-ID: Date: Thu, 16 Nov 2023 17:33:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [committed] hppa: Revise REG+D address support to allow long displacements before reload Content-Language: en-US To: Jeff Law , John David Anglin , GCC Patches References: <3641c999-fe8e-4f75-a9f1-455d65cf39e6@gmail.com> From: John David Anglin Autocrypt: addr=dave.anglin@bell.net; keydata= xsFNBFJfN1MBEACxBrfJ+5RdCO+UQOUARQLSsnVewkvmNlJRgykqJkkI5BjO2hhScE+MHoTK MoAeKwoLfBwltwoohH5RKxDSAIWajTY5BtkJBT23y0hm37fN2JXHGS4PwwgHTSz63cu5N1MK n8DZ3xbXFmqKtyaWRwdA40dy11UfI4xzX/qWR3llW5lp6ERdsDDGHm5u/xwXdjrAilPDk/av d9WmA4s7TvM/DY3/GCJyNp0aJPcLShU2+1JgBxC6NO6oImVwW07Ico89ETcyaQtlXuGeXYTK UoKdEHQsRf669vwcV5XbmQ6qhur7QYTlOOIdDT+8zmBSlqBLLe09soATDciJnyyXDO1Nf/hZ gcI3lFX86i8Fm7lQvp2oM5tLsODZUTWVT1qAFkHCOJknVwqRZ8MfOvaTE7L9hzQ9QKgIKrSE FRgf+gs1t1vQMRHkIxVWb730C0TGiMGNn2oRUV5O5QEdb/tnH0Te1l+hX540adKZ8/CWzzW9 vcx+qD9IWLRyZMsM9JnmAIvYv06+YIcdpbRYOngWPd2BqvktzIs9mC4n9oU6WmUhBIaGOGnt t/49bTRtJznqm/lgqxtE2NliJN79dbZJuJWe5HkjVa7mP4xtsG59Rh2hat9ByUfROOfoZ0dS sVHF/N6NLWcf44trK9HZdT/wUeftEWtMV9WqxIwsA4cgSHFR2QARAQABzTdKb2huIERhdmlk IEFuZ2xpbiAoRGViaWFuIFBvcnRzKSA8ZGF2ZS5hbmdsaW5AYmVsbC5uZXQ+wsF3BBMBCAAh BQJSXzdTAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJEF2/za5fGU3xs/4P/15sNizR ukZLNYoeGAd6keRtNcEcVGEpRgzc/WYlXCRTEjRknMvmCu9z13z8qB9Y9N4JrPdp+NQj5HEs ODPI+1w1Mjj9R2VZ1v7suFwhjxMTUQUjCsgna1H+zW/UFsrL5ERX2G3aUKlVdYmSWapeGeFL xSMPzawPEDsbWzBzYLSHUOZexMAxoJYWnpN9JceEcGvK1SU2AaGkhomFoPfEf7Ql1u3Pgzie ClWEr2QHl+Ku1xW0qx5OLKHxntaQiu30wKHBcsF0Zx2uVGYoINJl/syazfZyKTdbmJnEYyNa Bdbn7B8jIkVCShLOWJ8AQGX/XiOoL/oE9pSZ60+MBO9qd18TGYByj0X2PvH+OyQGul5zYM7Q 7lT97PEzh8xnib49zJVVrKDdJds/rxFwkcHdeppRkxJH0+4T0GnU2IZsEkvpRQNJAEDmEE8n uRfssr7RudZQQwaBugUGaoouVyFxzCxdpSYL6zWHA51VojvJYEBQDuFNlUCqet9LtNlLKx2z CAKmUPTaDwPcS3uOywOW7WZrAGva1kz9lzxZ+GAwgh38HAFqQT8DQvW8jnBBG4m4q7lbaum3 znERv7kcfKWoWS7fzxLNTIitrbpYA3E7Zl9D2pDV3v55ZQcO/M35K9teRo6glrtFDU/HXM+r ABbh8u9UnADbPmJr9nb7J0tZUSS/zsFNBFJfN1MBEADBzhVn4XyGkPAaFbLPcMUfwcIgvvPF UsLi9Q53H/F00cf7BkMY40gLEXvsvdUjAFyfas6z89gzVoTUx3HXkJTIDTiPuUc1TOdUpGYP hlftgU+UqW5O8MMvKM8gx5qn64DU0UFcS+7/CQrKOJmzktr/72g98nVznf5VGysa44cgYeoA v1HuEoqGO9taA3Io1KcGrzr9cAZtlpwj/tcUJlc6H5mqPHn2EdWYmJeGvNnFtxd0qJDmxp5e YVe4HFNjUwsb3oJekIUopDksAP41RRV0FM/2XaPatkNlTZR2krIVq2YNr0dMU8MbMPxGHnI9 b0GUI+T/EZYeFsbx3eRqjv1rnNg2A6kPRQpn8dN3BKhTR5CA7E/cs+4kTmV76aHpW8m/NmTc t7KNrkMKfi+luhU2P/sKh7Xqfbcs7txOWB2V4/sbco00PPxWr20JCA5hYidaKGyQxuXdPUlQ Qja4WJFnAtBhh3Oajgwhbvd6S79tz1acjNXZ89b8IN7yDm9sQ+4LhWoUQhB5EEUUUVQTrzYS yTGN1YTTO5IUU5UJHb5WGMnSPLLArASctOE01/FYnnOGeU+GFIeQp91p+Jhd07hUr6KWYeJY OgEmu+K8SyjfggCWdo8aGy0H3Yr0YzaHeK2HrfC3eZcUuo+yDW3tnrNwM1rd1i3F3+zJK18q GnBxEQARAQABwsFfBBgBCAAJBQJSXzdTAhsMAAoJEF2/za5fGU3xNDQP/ikzh1NK/UBrWtpN yXLbype4k5/zyQd9FIBxAOYEOogfKdkp+Yc66qNf36gO6vsokxsDXU9me1n8tFoB/DCdzKbQ /RjKQRMNNR4fT2Q9XV6GZYSL/P2A1wzDW06tEI+u+1dV40ciQULQ3ZH4idBW3LdN+nloQf/C qoYkOf4WoLyhSzW7xdNPZqiJCAdcz9djN79FOz8US+waBCJrL6q5dFSvvsYj6PoPJkCgXhiJ hI91/ERMuK9oA1oaBxCvuObBPiFlBDNXZCwmUk6qzLDjfZ3wdiZCxc5g7d2e2taBZw/MsKFc k+m6bN5+Hi1lkmZEP0L4MD6zcPuOjHmYYzX4XfQ61lQ8c4ztXp5cKkrvaMuN/bD57HJ6Y73Q Y+wVxs9x7srl4iRnbulCeiSOAqHmwBAoWaolthqe7EYL4d2+CjPCcfIuK7ezsEm8c3o3EqC4 /UpL1nTi0rknRTGc0VmPef+IqQUj33GGj5JRzVJZPnYyCx8sCb35Lhs6X8ggpsafUkuKrH76 XV2KRzaE359RgbM3pNEViXp3NclPYmeu+XI8Ls/y6tSq5e/o/egktdyJj+xvAj9ZS18b10Jp e67qK8wZC/+N7LGON05VcLrdZ+FXuEEojJWbabF6rJGN5X/UlH5OowVFEMhD9s31tciAvBwy T70V9SSrl2hiw38vRzsl Cc: Sam James In-Reply-To: <3641c999-fe8e-4f75-a9f1-455d65cf39e6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-11-16 4:52 p.m., Jeff Law wrote: > > > On 11/16/23 10:54, John David Anglin wrote: >> Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11.  Committed >> to trunk. >> >> This patch works around problem compiling python3.11 by improving >> REG+D address handling.  The change results in smaller code and >> reduced register pressure. >> >> Dave >> --- >> >> hppa: Revise REG+D address support to allow long displacements before reload >> >> In analyzing PR rtl-optimization/112415, I realized that restricting >> REG+D offsets to 5-bits before reload results in very poor code and >> complexities in optimizing these instructions after reload.  The >> general problem is long displacements are not allowed for floating >> point accesses when generating PA 1.1 code.  Even with PA 2.0, there >> is a ELF linker bug that prevents using long displacements for >> floating point loads and stores. >> >> In the past, enabling long displacements before reload caused issues >> in reload.  However, there have been fixes in the handling of reloads >> for floating-point accesses.  This change allows long displacements >> before reload and corrects a couple of issues in the constraint >> handling for integer and floating-point accesses. >> >> 2023-11-16  John David Anglin  >> >> gcc/ChangeLog: >> >>     PR rtl-optimization/112415 >>     * config/pa/pa.cc (pa_legitimate_address_p): Allow 14-bit >>     displacements before reload.  Simplify logic flow.  Revise >>     comments. >>     * config/pa/pa.h (TARGET_ELF64): New define. >>     (INT14_OK_STRICT): Update define and comment. >>     * config/pa/pa64-linux.h (TARGET_ELF64): Define. >>     * config/pa/predicates.md (base14_operand): Don't check >>     alignment of short displacements. >>     (integer_store_memory_operand): Don't return true when >>     reload_in_progress is true.  Remove INT_5_BITS check. >>     (floating_point_store_memory_operand): Don't return true when >>     reload_in_progress is true.  Use INT14_OK_STRICT to check >>     whether long displacements are always okay. > I strongly suspect this is going to cause problems in the end. > > I've already done what you're trying to do.  It'll likely look fine for an extended period of time, but it will almost certainly break one day. I could happen.  If it happens and can't be fixed, it's easy enough to return false in pa_legitimate_address_p before reload.  Maybe we could add an optimization option for this. As it stands, the code improvement for python is significant.  I don't think f-m-o can fix things after reload. Hopefully, Sam will test the change with various package builds on gentoo.  Debian is still on gcc-13. I'm not seeing any obvious problems in the gcc testsuite.  It needs testing on packages that do extensive floating point calculations. Dave -- John David Anglin dave.anglin@bell.net