From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40043.outbound.protection.outlook.com [40.107.4.43]) by sourceware.org (Postfix) with ESMTPS id 920A23858D3C for ; Wed, 8 Dec 2021 15:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 920A23858D3C Received: from DB9PR02CA0018.eurprd02.prod.outlook.com (2603:10a6:10:1d9::23) by HE1PR0801MB2075.eurprd08.prod.outlook.com (2603:10a6:3:51::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Wed, 8 Dec 2021 15:40:00 +0000 Received: from DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::be) by DB9PR02CA0018.outlook.office365.com (2603:10a6:10:1d9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Wed, 8 Dec 2021 15:40:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT013.mail.protection.outlook.com (10.152.20.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.13 via Frontend Transport; Wed, 8 Dec 2021 15:40:00 +0000 Received: ("Tessian outbound de6049708a0a:v110"); Wed, 08 Dec 2021 15:39:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7f4ae3da6f2ca332 X-CR-MTA-TID: 64aa7808 Received: from a631fb2f2996.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 79D475B2-C99D-4C96-A381-CB93A63B4271.1; Wed, 08 Dec 2021 15:39:35 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a631fb2f2996.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Dec 2021 15:39:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yosq+d4kZqDutcUfwLCtdDJbnyScqWdt/CJL1MCBxf77fXDAKQcIVa/Qu2p0YN4DR2Pgw25+CD9T+wHMG8fIvwzHokx9bANs0GDS8D6mnjnVbbTBJHx6jc1SeXVM6taKhl64sbNlFnMp3CQcZbe4KNG0h3+D84x8MKyyqBBD19r8kppRdz5ky2qUKkdFhOz2Fp+KOgy+RNmMGmVuGK4TBnx+0/NuSOVlckRsgBnU+jZ5kAZ1MPJ4LE10Pqpci56436oJ/JXvGdxDiyPNXGSyHU/zsa1U6Wxs3MLXn4183NTV2qy2+s4pMr7T1t/PC+rVBt15UOsWm5DLiWLVetxcCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8eIeD9wAjYh5HW9VFcEoq5YHPMMAIqUg3oVPbww0CmE=; b=QsQif33CZH4OyAWUpSrB5jfcZ54725P5IeIjNeIBSJF/iG2OVDRJrGU33TEeAAa5pweJG055E9KRF88DgSw5KdJn6fAWbry65KSV6OaXGMwBDPkWQw8y3yAhkOOtxMjSZK2EYJ7YJjmkVYsCOch67nmiiKRphDN57tckyDHrkPxtAR95tWXunb2nndPxPJdtzKHCwRYtwHGs2PbE5YSmekvTHVmUGvxcofECzjkPseHrG1Sls+vIuqQKxoEB3fZYRCCp2hdUmOXzFP9d/DR7tlP+WvE2kYYMFhZIYAWINykPZICte6qgBWVg0PPMG2JQx44EdXDCLICjiZ/iUUXmhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB5175.eurprd08.prod.outlook.com (2603:10a6:20b:ef::11) by AM5PR0801MB1620.eurprd08.prod.outlook.com (2603:10a6:203:3a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Wed, 8 Dec 2021 15:39:24 +0000 Received: from AM6PR08MB5175.eurprd08.prod.outlook.com ([fe80::8d8f:5a4a:c1f8:c305]) by AM6PR08MB5175.eurprd08.prod.outlook.com ([fe80::8d8f:5a4a:c1f8:c305%6]) with mapi id 15.20.4755.022; Wed, 8 Dec 2021 15:39:23 +0000 Subject: Re: [PATCH 2/2][GCC] arm: Declare MVE types internally via pragma To: Richard Earnshaw References: <55ba6a8c-4dda-c023-0e93-a052e4830d06@arm.com> <342ef4e3-6013-2d67-adc8-6310febe2f52@foss.arm.com> <2a59e081-0a5f-5b9b-c398-d89c6c217822@arm.com> <9ccc226a-fdf7-d465-6074-b6a78d16b316@arm.com> <060230b8-22b0-36eb-2594-c469efaabf35@arm.com> <3ad22fca-fa13-04ea-f114-01e8c52dd280@foss.arm.com> From: Murray Steele Cc: gcc-patches@gcc.gnu.org Message-ID: Date: Wed, 8 Dec 2021 15:39:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <3ad22fca-fa13-04ea-f114-01e8c52dd280@foss.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0281.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::16) To AM6PR08MB5175.eurprd08.prod.outlook.com (2603:10a6:20b:ef::11) MIME-Version: 1.0 Received: from [10.32.99.44] (217.140.106.32) by LO4P123CA0281.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20 via Frontend Transport; Wed, 8 Dec 2021 15:39:23 +0000 X-MS-Office365-Filtering-Correlation-Id: 9b3f09cb-0b5c-4ee2-e6e8-08d9ba60feaa X-MS-TrafficTypeDiagnostic: AM5PR0801MB1620:EE_|DB5EUR03FT013:EE_|HE1PR0801MB2075:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lvFwU7rwYqLVu4Um57be/YbXkK96HdrGEF55SqVt+UQ5r/a43UqucvFF/OBJJdsrqs8SMUueHuph8OQciTWboMv1XlLD5XR3YxW3oYzQh0ujDolvMhkHZo+EOt0OgRm/u4cAjtH90fG4PlOp1/cpfEtdfC3sq7hBI4JSfOsDIHZzzdHTGtrNROcpX+E08erwk8fNjSGxj5C+FHyFs4DlRJcS4LkVFnFINMYO4RFljZIkXIkgOoKbeopdq/HihiGCOV7ItB+suNs0znnrIamBfRo52st2tJp4i+9VW7cFbNYKFlg+HDb+kQoK/mCZaN0ZsAxIPFVIOhIbthIOyTTlVWAC57bhKWmyyauX2X4pRdx6KGMeHN6199jBFZZt7kZum6IjAcc7s5InmTbL1cd33giR8MDZRoAFPx4v+UVrmyB/tgykjQSMBuThNjKGR/8gCIs0e43eUzI1B5pLhInHJfkXk2S0FPGCzA3Rn5SU2/jKPHmiLthRyF0smQ5f/9ND2JSGzr3dvM945le1n/WbjSSbDkyU1lGMMQV2t56/1JJABkmsLm6UU8FT2gGauNZv1DZq0YtXnIqsj7HRq4dX5DTmIo1KZgsLH4h2/4kxS+9RGVto7ovcAkaivZzOrkwi/Sx1pzmLWiMJls1pE9CtEr8CeQnXnPVtewDUFdX1r88hKegwRg+XO0ZngUxtY8nzgmVdhBKzpGnn5L4UaeALoFtlW8CVw5nZnffdEJlgRjg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB5175.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(2906002)(66556008)(66476007)(36756003)(956004)(26005)(186003)(6862004)(38100700002)(31696002)(31686004)(5660300002)(2616005)(316002)(53546011)(86362001)(508600001)(4326008)(8936002)(16576012)(8676002)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1620 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1478e835-1b90-42f5-16b2-08d9ba60e8f2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a+MKaAi/eBWqYOxk2jzrPnUlzaCN0dtzfTRDdxWocF6mni97vgmOsqSRuz9jgtzrbSykt5CRnJAKjXztSxzZWY4YccsQyt0LdvCDiuu94tjaGGK1simDod+Rf80Q/sBUImBUVIi8PS2p1rnoVRVfARqEzUvkksjdsz8Q3mGGhWuAbt+sUVwgGOproUm3aRi0AcF9bnTq/Rjtgr73Tu4D/M3QryP/fZGcIcGDRKEkMhk3VSv6rhu9lNlceB5fuGq0XFkUu+4MOw1RNJ1GY40wx6PxA/k5VBOj8GVZ/8tzxgY8j8gJeRc7iOr116Xrzi92NuCqgizCyIq6Hfia296C+HBOGtYSg4TeewK0vDMhJjKeHz7cFvV43LfUzYLikEAshvXZwnEEonJheV1cLZ7cpnFOtCXPzGErmBLNzK3IKrI0sBISUe94CXt4uAukUsOHrNjN0gMWEGdyCnO6M7QAgUEXn8y9vzfe0T4mWmRuL2RLq7PD4DXMnbVyH33urCokncnVDdVaeGmugnwjqb7jySwASyqXTadbjf5ZvvLrEOTMHflaiIXWhJv+r8CnskTrddEziuHKzTZDx5ZtSVtPYiHks9QoVgTNzLcWl1EjsMQew3z5+j27Q5tS7j1Al8PcFiAbiedjlhQiPVYcJXyC9z5Y+1pJTH3WHy3cXYQXyhlZgPQTHzwhmID2jyPFhfB56B22FEquOBNe7pRxSY04iqlI8QsZl42fnKVXTxEQh3ToVC3TnMXg+vKFTZuRn1ULOkVXukNNA0Zle6BhcBGg80e7hc0hKDjBjv9p1bh2lpw= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(40470700001)(5660300002)(53546011)(31696002)(316002)(26005)(16576012)(508600001)(956004)(4326008)(8936002)(6862004)(186003)(8676002)(336012)(36860700001)(31686004)(47076005)(82310400004)(356005)(40460700001)(81166007)(2616005)(86362001)(2906002)(70206006)(36756003)(6486002)(70586007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:40:00.1611 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b3f09cb-0b5c-4ee2-e6e8-08d9ba60feaa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2075 X-Spam-Status: No, score=-14.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 15:40:08 -0000 Hi, Thank you for the feedback, I'll make the noted changes to the changelog and add the missing end-of-namespace comments. On 08/12/2021 15:23, Richard Earnshaw wrote: > diff --git a/gcc/config/arm/arm-mve-builtins.def b/gcc/config/arm/arm-mve-builtins.def > new file mode 100644 > index 0000000000000000000000000000000000000000..02a46bec3e4cba6add9bce4021c732e15aa8b012 > --- /dev/null > +++ b/gcc/config/arm/arm-mve-builtins.def > @@ -0,0 +1,41 @@ > > +#ifndef DEF_MVE_TYPE > +#define DEF_MVE_TYPE(A, B) > +#endif > > When would this file ever be included when this macro wasn't defined? Better to require the caller to define this by using #error if it's missing. > > then... > > + > +#undef DEF_MVE_TYPE > > This isn't needed anymore, because caller should undef it after use. I'd added this because later patches that build from this series will most likely need to define further DEF_MVE_* macros, in the style of the current SVE implementation. You are right that it is unnecessary for right now though, and I'll remove it too. Thanks again, Murray