From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1947 invoked by alias); 25 Jul 2018 13:09:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1933 invoked by uid 89); 25 Jul 2018 13:09:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70079.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jul 2018 13:09:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/B+rwkBanzERTnLAoxZpdmDHT/ZgLf3o68hCn49GEk=; b=G8fLk1T429kKRJQyUMQiZqJH1PDdAmDCu718bty9q9ksTDa3daMoP+iDV3TM8SoKhSLNCMDbVaVpkMYQePM+y+/L67OLJzgQ8+NuR9aKXm9q6Stpy2eng+m+VIn7U1GYgtJXDYJ1t59NuiKJjMxuWabEfurkiNqV91TxbRILU/0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Sam.Tebbs@arm.com; Received: from [10.2.206.193] (217.140.96.140) by AM6PR08MB3432.eurprd08.prod.outlook.com (2603:10a6:20b:44::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Wed, 25 Jul 2018 13:08:58 +0000 Subject: Re: [GCC][PATCH][Aarch64] Stop redundant zero-extension after UMOV when in DI mode To: Sudakshina Das , "gcc-patches@gcc.gnu.org" Cc: Marcus Shawcroft , nd , Richard Earnshaw , James Greenhalgh References: <953dbdd2-e20c-4587-3e0d-ad1a65fc93c6@arm.com> <85b58ddb-3da2-67c6-1514-e308201191d3@arm.com> From: Sam Tebbs Message-ID: Date: Wed, 25 Jul 2018 13:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <85b58ddb-3da2-67c6-1514-e308201191d3@arm.com> Content-Type: multipart/mixed; boundary="------------5B589EBB67E32D3327D7BE57" Return-Path: sam.tebbs@arm.com Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg01528.txt.bz2 This is a multi-part message in MIME format. --------------5B589EBB67E32D3327D7BE57 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 2892 On 07/23/2018 05:01 PM, Sudakshina Das wrote: > Hi Sam > > > On Monday 23 July 2018 11:39 AM, Sam Tebbs wrote: >> Hi all, >> >> This patch extends the aarch64_get_lane_zero_extendsi instruction >> definition to >> also cover DI mode. This prevents a redundant AND instruction from being >> generated due to the pattern failing to be matched. >> >> Example: >> >> typedef char v16qi __attribute__ ((vector_size (16))); >> >> unsigned long long >> foo (v16qi a) >> { >>   return a[0]; >> } >> >> Previously generated: >> >> foo: >>         umov    w0, v0.b[0] >>         and     x0, x0, 255 >>         ret >> >> And now generates: >> >> foo: >>         umov    w0, v0.b[0] >>         ret >> >> Bootstrapped on aarch64-none-linux-gnu and tested on aarch64-none-elf >> with no >> regressions. >> >> gcc/ >> 2018-07-23  Sam Tebbs >> >>         * config/aarch64/aarch64-simd.md >>     (*aarch64_get_lane_zero_extendsi): >>         Rename to... >> (*aarch64_get_lane_zero_extend): ... This. >>         Use GPI iterator instead of SI mode. >> >> gcc/testsuite >> 2018-07-23  Sam Tebbs >> >>         * gcc.target/aarch64/extract_zero_extend.c: New file >> > You will need an approval from a maintainer, but I would only add one > request to this: > > diff --git a/gcc/config/aarch64/aarch64-simd.md > b/gcc/config/aarch64/aarch64-simd.md > index 89e38e6..15fb661 100644 > --- a/gcc/config/aarch64/aarch64-simd.md > +++ b/gcc/config/aarch64/aarch64-simd.md > @@ -3032,15 +3032,16 @@ >    [(set_attr "type" "neon_to_gp")] >  ) > > -(define_insn "*aarch64_get_lane_zero_extendsi" > -  [(set (match_operand:SI 0 "register_operand" "=r") > -    (zero_extend:SI > +(define_insn "*aarch64_get_lane_zero_extend" > +  [(set (match_operand:GPI 0 "register_operand" "=r") > +    (zero_extend:GPI > > Since you are adding 4 new patterns with this change, could you add > more cases in your test as well to make sure you have coverage for > each of them. > > Thanks > Sudi Hi Sudi, Thanks for the feedback. Here is an updated patch that adds more testcases to cover the patterns generated by the different mode combinations. The changelog and description from my original email still apply. > >        (vec_select: >          (match_operand:VDQQH 1 "register_operand" "w") >          (parallel [(match_operand:SI 2 "immediate_operand" "i")]))))] >    "TARGET_SIMD" >    { > -    operands[2] = aarch64_endian_lane_rtx (mode, INTVAL > (operands[2])); > +    operands[2] = aarch64_endian_lane_rtx (mode, > +                       INTVAL (operands[2])); >      return "umov\\t%w0, %1.[%2]"; >    } >    [(set_attr "type" "neon_to_gp")] --------------5B589EBB67E32D3327D7BE57 Content-Type: text/x-patch; name="latest.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="latest.patch" Content-length: 2222 diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md index f1784d72e55c412d076de43f2f7aad4632d55ecb..e92a3b49c65e84d2a16a2a480c359a0b4d8fa3e3 100644 --- a/gcc/config/aarch64/aarch64-simd.md +++ b/gcc/config/aarch64/aarch64-simd.md @@ -3033,15 +3033,16 @@ [(set_attr "type" "neon_to_gp")] ) -(define_insn "*aarch64_get_lane_zero_extendsi" - [(set (match_operand:SI 0 "register_operand" "=r") - (zero_extend:SI +(define_insn "*aarch64_get_lane_zero_extend" + [(set (match_operand:GPI 0 "register_operand" "=r") + (zero_extend:GPI (vec_select: (match_operand:VDQQH 1 "register_operand" "w") (parallel [(match_operand:SI 2 "immediate_operand" "i")]))))] "TARGET_SIMD" { - operands[2] = aarch64_endian_lane_rtx (mode, INTVAL (operands[2])); + operands[2] = aarch64_endian_lane_rtx (mode, + INTVAL (operands[2])); return "umov\\t%w0, %1.[%2]"; } [(set_attr "type" "neon_to_gp")] diff --git a/gcc/testsuite/gcc.target/aarch64/extract_zero_extend.c b/gcc/testsuite/gcc.target/aarch64/extract_zero_extend.c new file mode 100644 index 0000000000000000000000000000000000000000..deb613cd23150a83dfd36ae84504415993b97be3 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/extract_zero_extend.c @@ -0,0 +1,39 @@ +/* { dg-do compile } */ +/* { dg-options "-O3" } */ + +/* Tests *aarch64_get_lane_zero_extenddiv16qi. */ +typedef unsigned char v16qi __attribute__ ((vector_size (16))); +/* Tests *aarch64_get_lane_zero_extenddiv8qi. */ +typedef unsigned char v8qi __attribute__ ((vector_size (8))); + +/* Tests *aarch64_get_lane_zero_extendsiv8hi. */ +typedef unsigned short v16hi __attribute__ ((vector_size (16))); +/* Tests *aarch64_get_lane_zero_extendsiv4hi. */ +typedef unsigned short v8hi __attribute__ ((vector_size (8))); + +unsigned long long +foo_16qi (v16qi a) +{ + return a[0]; +} + +unsigned long long +foo_8qi (v8qi a) +{ + return a[0]; +} + +unsigned int +foo_16hi (v16hi a) +{ + return a[0]; +} + +unsigned int +foo_8hi (v8hi a) +{ + return a[0]; +} + +/* { dg-final { scan-assembler-times "umov\\t" 4 } } */ +/* { dg-final { scan-assembler-not "and\\t" } } */ --------------5B589EBB67E32D3327D7BE57--