From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 3DD36385771F for ; Tue, 23 May 2023 03:52:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DD36385771F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-64d1e96c082so3808392b3a.1 for ; Mon, 22 May 2023 20:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1684813965; x=1687405965; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0zWD3A1W5MsM01jSCnZpNqDyipjxWvBaJfn9mho8c7E=; b=m1A67YabUbbS9283uQMMX5+VdNrCc/SZp4vL/mJnGZ+Eft4l4PhyrtIqDysqSGRvyP RBj+iP2NXb2gK1KJ4vhNDslVyIadMcHgexMqIK/GuOsWjaIBZe98dpmI091ijxe+4qp1 oT6yuBGpyZDCiiJhywMXRnYCijuMrBgyqMHrS5reUhAFJEFIB86sY6mVp0JQoDyZcF0o jsRxIA4NdtoPS22cJBNuQXkqlkqDRXi4pnb88JXy01DMUQVXY4g8L1TSSH8+SThM/oxV nWcyi12x4ULdkna9CeGRLH3jXwdaSVCUm+isxtdHzb7X9iiU9RMRVXI4NO72tNrifO7a Ga0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684813965; x=1687405965; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0zWD3A1W5MsM01jSCnZpNqDyipjxWvBaJfn9mho8c7E=; b=lQqDO8j2yyqXt4mlxzYYj/cPzS76EnLuUsoHx6wJhN9gCYNwzAnQ5/XafT+V56GybE 9RCgebMkqqdLk5VX0y6ahRnk0PlAL+y2PLv+oEdvbQiOamT4cNzkh/BrFQ2ji1Pr9K04 q0zAjC1R1im+Ah3FTcoDNmDJ+vlcY2+2jksmuChId4QJYvXzmjdtNKV/WMfnLigYR/W3 vlg35GYDEHmM4pHnEwdgwK1449h4FeQHP2Np32kpVsW6l4wE59qad8of9bH/HYYaWaws 9tIpYhZ/CnMcRd+KNxLppHFY6T6heUSPyMJN/jmvzu8MXJF+PORvmNYM2Cgz581inaEf Tk7g== X-Gm-Message-State: AC+VfDyROf3KYfIGO6z29sBbXkZyW5ZlUMs8VRJAD8SCEL9pVfJUMQ+j xjnbf8px8Pnd+wLdORWVMAVh+w== X-Google-Smtp-Source: ACHHUZ4RI5vUUsP3kUiiI3Jnc6UZcT1CLiZTH0n5QHEcPR2kLBQhLVrR9S6bUzLpEgoj59WsyKL7gw== X-Received: by 2002:a05:6a00:10c4:b0:63b:1708:10aa with SMTP id d4-20020a056a0010c400b0063b170810aamr16212018pfu.34.1684813965139; Mon, 22 May 2023 20:52:45 -0700 (PDT) Received: from [192.168.50.116] ([71.202.114.183]) by smtp.gmail.com with ESMTPSA id c5-20020aa78e05000000b0064d2ad04cccsm4960462pfr.175.2023.05.22.20.52.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 20:52:44 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 20:52:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp Content-Language: en-US To: Kito Cheng , gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, patrick@rivosinc.com, jlaw@ventanamicro.com References: <20230522064138.74056-1-kito.cheng@sifive.com> From: Vineet Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/22/23 02:17, Kito Cheng wrote: > Ooops, seems still some issue around here, Yep still 5000 fails :-( > but I found something might > related this issue: > > https://github.com/gcc-mirror/gcc/commit/d6654a4be3ba44c0d57be7c8a51d76d9721345e1 > https://github.com/gcc-mirror/gcc/commit/23c49bb8d09bc3bfce9a08be637cf32ac014de56 It seems both of these patches are essentially doing what yours did. So something else is amiss still. Thx, -Vineet > > On Mon, May 22, 2023 at 2:42 PM Kito Cheng wrote: >> Hi Vineet: >> >> Could you help to test this patch, this could resolve that issue on our >> machine, but I would like to also work for other env. >> >> Thanks :) >> >> --- >> >> We got bunch of following error message for multi-lib run: >> >> ERROR: torture-init: torture_without_loops is not empty as expected >> ERROR: tcl error code NONE >> >> And seems we need torture-init and torture-finish around the test >> loop. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/riscv/rvv/rvv.exp: Add torture-init and >> torture-finish. >> --- >> gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> index bc99cc0c3cf4..19179564361a 100644 >> --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> @@ -39,6 +39,7 @@ if [istarget riscv32-*-*] then { >> >> # Initialize `dg'. >> dg-init >> +torture-init >> >> # Main loop. >> set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3" >> @@ -69,5 +70,7 @@ foreach op $AUTOVEC_TEST_OPTS { >> dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/autovec/vls-vlmax/*.\[cS\]]] \ >> "-std=c99 -O3 -ftree-vectorize --param riscv-autovec-preference=fixed-vlmax" $CFLAGS >> >> +torture-finish >> + >> # All done. >> dg-finish >> -- >> 2.40.1 >>