From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id DB2853853802 for ; Fri, 28 May 2021 04:20:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DB2853853802 Received: by mail-pg1-x533.google.com with SMTP id m190so1595298pga.2 for ; Thu, 27 May 2021 21:20:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=UwF2J9fp+Eg+rHJq+G7+e8xuG8bQBA8MZpQ1mNgbsuM=; b=etsSAtpGCnTADXgPdMgRVq6+PIgM4AyexmcbUB3Mvjk8fJtAI+SZc6S0VuL+eUiVZ4 CxqMhuclWISTVWITkUWyeL9ocWY6Qdq7LFydqN6PIvAZlvJDEPZ/pfXoC4sWfpU9W/8i /NdLVPZCZc5Y2aGMBP5IfYNEKyn80gHMxExE6jflMTafcu47C31oIvXlMSuQ4+v3X04d LkYwAo1N2ojM7MrBssT/JQ0cksILUXHxcNshNDd3ArELYJyoeWoGd6CGWE9g0S31OoeI hW8zVIXXFzPYFpGo4jQ3rHLt+C40VSTHQtTvsfjwHUkg1N6tJY9aXmqertrD8MGYwEmu FDOA== X-Gm-Message-State: AOAM532eHUXL+lQIcod671rd+QuNc3/5oaFpfvJmAT7zbp16+cnwXkSU DZF++KzpNUgdhX2M0TWHvgTX8ARsuBxwJQ== X-Google-Smtp-Source: ABdhPJwMACpbRHK3o0+F4nYTzClaT9bhIlm5PHlX7UefW7KiVhq1rqhXEiafbFneq0F7OZdN9YiYGg== X-Received: by 2002:a63:1149:: with SMTP id 9mr7060804pgr.156.1622175617644; Thu, 27 May 2021 21:20:17 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id s11sm3199564pfm.95.2021.05.27.21.20.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 21:20:17 -0700 (PDT) Subject: Re: [PATCH] Remove CC0 To: Segher Boessenkool , "H.J. Lu" Cc: gcc-patches@gcc.gnu.org References: <952b5c888a98df98249088d81e954d64fad88827.1620082370.git.segher@kernel.crashing.org> <20210527222816.GB3085@gate.crashing.org> From: Jeff Law Message-ID: Date: Thu, 27 May 2021 22:20:15 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210527222816.GB3085@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2021 04:20:21 -0000 On 5/27/2021 4:28 PM, Segher Boessenkool wrote: > On Thu, May 27, 2021 at 12:58:10PM -0700, H.J. Lu wrote: >> You missed: >> >> config/cr16/cr16.md: (clobber (cc0))] >> config/cr16/cr16.md: [(parallel [(set (cc0) >> config/cr16/cr16.md: [(set (cc0) >> config/cr16/cr16.md: [(cc0) (const_int 0)]))] >> config/cr16/cr16.md: [(set (cc0) >> config/cr16/cr16.md: [(cc0) (const_int 0)]))] >> >> Now, cr16-elf won't build. > I did not miss that. I did not convert targets away from cc0 here. We > deprecated cc0 long ago, and it is time to remove it now. cr16 is the > one target that still uses cc0. It should be relatively trivial to move > to the modern world: two expanders, two insns; and only cmp, cbranch, > cstore for that matter; anyone who knows cr16 at all can probably do it. > But that is not me, I do not know how to *test* cr16 at all. Similarly, I'm aware of it (it's failing in the tester), but I have neither the time nor the inclination to fix it. Jeff