Re: [committed] Enable LRA on several ports

[Jeff Law <jeffreyalaw@gmail.com>]

On 8/13/23 20:11, Hans-Peter Nilsson wrote:
> On Mon, 1 May 2023, Jeff Law wrote:
> 
>>
>> Spurred by Segher's RFC, I went ahead and tested several ports with LRA
>> enabled.  Not surprisingly, many failed, but a few built their full set of
>> libraries successful and of those a few even ran their testsuites with no
>> regressions.  In fact, enabling LRA fixes a small number of failures on the
>> iq2000 port.
>>
>> This patch converts the ports which built their libraries and have test
>> results that are as good as or better than without LRA.    There may be minor
>> code quality regressions or there may be minor code quality improvements --
>> I'm leaving that for the port maintainers to own going forward.
> 
> How do you configure your builds?  Perhaps your cross-builds
> exclude C++?  I found that this (r14-383) broke MMIX building
> libstdc++-v3 from that commit up to and including r14-3180.
> See commit r14-3187.
Mine configure without C++ for the embedded targets.  So that would 
explain why my testing was clean and yours failed during build time.

> 
> Thankfully there was just one single gotcha.  I temporarily
> reverted the LRA change for MMIX so that I can get honest
> repeatable baseline results.  There seems to have been one
> test-case regressing from the LRA switch (PR53948), thus I
> re-enabled LRA for MMIX again.  Sorry for the late reaction.
Thanks.  ANd I'm sorry for 1. breaking things and 2. for responding so 
damn slowly.

jeff