From: Nathan Sidwell <nathan@acm.org>
To: gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Reimplement ADL
Date: Thu, 25 May 2017 19:42:00 -0000 [thread overview]
Message-ID: <ba694a5c-35d8-93dc-d5cd-25d78b387200@acm.org> (raw)
In-Reply-To: <CADzB+2n=CR+t1BzGhFtYABc8XM4bUp7H=H3Fx0LkcA+OuB3qvA@mail.gmail.com>
On 05/25/2017 03:07 PM, Jason Merrill wrote:
>> The recursion is a rare event, so we optimize the non-recursive case.
>
> Sounds like it would make sense to use a hash_set rather than flags on
> the decls.
I don't think that would be a win. Although both are O(1), the constant
factor is greater for the hash_set. As I said, it is rare -- I think
there was only once instance in building libstdc++ or in its testsuite,
I can't recall which.
The cost of fixing it up is pretty cheap anyway -- iterate over the
vector of seen scopes.
nathan
--
Nathan Sidwell
next prev parent reply other threads:[~2017-05-25 19:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 13:26 Nathan Sidwell
2017-05-25 19:17 ` Jason Merrill
2017-05-25 19:42 ` Nathan Sidwell [this message]
2017-05-26 8:08 ` Jakub Jelinek
2017-05-26 11:38 ` Nathan Sidwell
2017-05-26 11:50 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba694a5c-35d8-93dc-d5cd-25d78b387200@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).