From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id A2F513858D32 for ; Mon, 5 Sep 2022 06:36:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2F513858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2855IHFt025617; Mon, 5 Sep 2022 06:36:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=GITtgr6dOnfYfjIBCg4hc08gceV+F5mX03ZdJrgNfKw=; b=q4uTcleAKqVrmsUxFYkXp3/jjE614IoZuZKPFeSYQJFOqggrsFkfjJ0GjVa4J5Vw6KCT a+5Wjlt0KWZRNnXxCEP/UG9kQZWkvkfjcB5+C+OIZIZeWHagk5y970RxbrxkdpVuTCjQ y8VsGFhqIB8xmjrGQZg45h3jjn12o4Smkz92rcOripkdofJr0Jnfxc2KmXjqts/HvR+h 6lGrZv/dQJzyL/2sb1Ruoppp3yDGwDgU0YBXIU8PvXPML2JgehKGMvatCjj5KcE+oyDR vqydTyytLkCkLTwIKi+HBbsVeM70aHWbv5R78rwlNgH+VOLoif5EOVV/M0LC21OHXUJc Ig== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jdaunhrg4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Sep 2022 06:36:40 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2856TBHX007784; Mon, 5 Sep 2022 06:36:39 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jdaunhrfe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Sep 2022 06:36:39 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2856ZwmS013939; Mon, 5 Sep 2022 06:36:37 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 3jbxj8t0kj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Sep 2022 06:36:37 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2856X8AZ41353682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Sep 2022 06:33:08 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 722E6A4053; Mon, 5 Sep 2022 06:36:34 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9722DA4040; Mon, 5 Sep 2022 06:36:32 +0000 (GMT) Received: from [9.200.40.150] (unknown [9.200.40.150]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 5 Sep 2022 06:36:32 +0000 (GMT) Message-ID: Date: Mon, 5 Sep 2022 14:36:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions Content-Language: en-US To: Segher Boessenkool Cc: gcc-patches , David , "Kewen.Lin" , Peter Bergner References: <3cd458bc-b01f-cc61-241a-f12d6a49bc87@linux.ibm.com> <20220902155604.GO25951@gate.crashing.org> From: HAO CHEN GUI In-Reply-To: <20220902155604.GO25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: aDLT8YLRp9R47f2vrsx8zYRNa8TzU1XU X-Proofpoint-ORIG-GUID: midT6fUWH89hdzMUoodM1jVC-sa892Wl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-05_04,2022-09-05_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 impostorscore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209050031 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Segher, Thanks for your review comments. On 2/9/2022 下午 11:56, Segher Boessenkool wrote: >> - const signed long __builtin_vsx_scalar_extract_exp (double); >> + const unsigned long long __builtin_vsx_scalar_extract_exp (double); >> VSEEDP xsxexpdp {} >> >> - const signed long __builtin_vsx_scalar_extract_sig (double); >> + const unsigned long long __builtin_vsx_scalar_extract_sig (double); >> VSESDP xsxsigdp {} > This also brings these legacy builtins in line with the vec_ versions, > which are the preferred builtins (they are defined in the PVIPR). The return type of vec_ version built-ins are different than their definition in PVIPR. In PVIPR, they're vector unsigned int or vector unsigned long long. Shall we correct them? const vd __builtin_vsx_extract_exp_dp (vd); VEEDP xvxexpdp {} const vf __builtin_vsx_extract_exp_sp (vf); VEESP xvxexpsp {} const vd __builtin_vsx_extract_sig_dp (vd); VESDP xvxsigdp {} const vf __builtin_vsx_extract_sig_sp (vf); VESSP xvxsigsp {} > >> --- a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >> +++ b/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >> @@ -1,7 +1,8 @@ >> -/* { dg-do compile { target { powerpc*-*-* } } } */ >> -/* { dg-require-effective-target lp64 } */ >> -/* { dg-require-effective-target powerpc_p9vector_ok } */ >> +/* { dg-do compile { target { powerpc*-*-linux* } } } */ > Why? The powerpc*-*-linux* is no need as bfp.exp excludes AIX and Darwin. I will modify it. > >> /* { dg-options "-mdejagnu-cpu=power9" } */ >> +/* { dg-additional-options "-mpowerpc64" } */ >> +/* { dg-require-effective-target has_arch_ppc64 } */ > This is guaranteed already by that -mpowerpc64. > > It probably is best if you do not add -mpowerpc64 at all. That solves > both problems, is simpler, and gives better coverage as well :-) > > So just use has_arch_ppc64 instead of lp64. That makes it run on a > strict superset of cases :-) We commonly do regression test with -m32 and -m64. So if -mpowerpc64 is not added, the combination of "-m32/-mpowerpc64" is not tested. Thanks Gui Haochen