From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5734B3858D28 for ; Thu, 28 Apr 2022 00:51:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5734B3858D28 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-83-IW09BQlANaWxZvJNVm6cRA-1; Wed, 27 Apr 2022 20:51:11 -0400 X-MC-Unique: IW09BQlANaWxZvJNVm6cRA-1 Received: by mail-qk1-f198.google.com with SMTP id u129-20020a372e87000000b0069f8a79378eso2260072qkh.5 for ; Wed, 27 Apr 2022 17:51:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=BBJeyILXoTZhg1kF4cCXI3jYR/JR5Z1jl0vTzjP9FM4=; b=0rhWGyoqFGFERed6/VwTTIuGUey90pOdIthwRDnNLkcNO2wGirbK8e+ioOgIKChynP EoyjqmTwMEVHv7B0q3H1nJFi3xDE3UJFyvfOhqL1Y0IBvQF2mbs4dITYHGY9yzXptlcY SeV4siyZrgDwMlSJwN1hMQV1zp0jo4iEQT9juheEgjDDE42t7jHqcdf/EcU5yyWQT+sJ IqrxoLlmVKU6g/T0p3ALraQMhVJfXH1X6F+s/ki22ziAZdVoYe70360mKaVe/Cz9E7V+ PTZ1xY4PmEXN3pcu+AzDspnfmq0ILwNYkyOTixDqOv0oUjWe4oiQVXNqMZi3ge9HgVoS xTFA== X-Gm-Message-State: AOAM533nWABfDQYXR6C/jlzfDmuejHsEOR/8nFe7MD+DxhFcznDQoV1E WEZ8GrLAox6G9uhn0NXp1/MCc1T/zcaHGsiynoOWh1NCV7NRcN8OgoIW9qADEVsq/qHh8sC+Xqs 3cN8dIJlnL9pPPSrpmQ== X-Received: by 2002:ad4:5943:0:b0:446:5c3e:2c2a with SMTP id eo3-20020ad45943000000b004465c3e2c2amr22156247qvb.75.1651107071009; Wed, 27 Apr 2022 17:51:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZLRBniZkq1ItFmqWBxdJqgjPo3EQELMJbujH1iVA5PtADVp44MFKpn6iJN1Pb76j0PORWTw== X-Received: by 2002:ad4:5943:0:b0:446:5c3e:2c2a with SMTP id eo3-20020ad45943000000b004465c3e2c2amr22156234qvb.75.1651107070736; Wed, 27 Apr 2022 17:51:10 -0700 (PDT) Received: from [192.168.1.100] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id g187-20020a37b6c4000000b0069f840cb643sm2723985qkf.102.2022.04.27.17.51.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 17:51:10 -0700 (PDT) Message-ID: Date: Wed, 27 Apr 2022 20:51:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] c++: global-namespace-qualified var after class def [PR90107] To: Marek Polacek , GCC Patches References: <20220427224526.1107353-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20220427224526.1107353-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2022 00:51:14 -0000 On 4/27/22 18:45, Marek Polacek wrote: > Here we wrongly reject the definition of "::N::a" > > struct A; > namespace N { extern A a; } > struct A {} ::N::a; > > because our code to diagnose a missing ; after a class definition doesn't > realize that :: can follow a class definition. > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/11.4? OK. > PR c++/90107 > > gcc/cp/ChangeLog: > > * parser.cc (cp_parser_class_specifier_1): Accept :: after a class > definition. > > gcc/testsuite/ChangeLog: > > * g++.dg/parse/qualified6.C: New test. > --- > gcc/cp/parser.cc | 1 + > gcc/testsuite/g++.dg/parse/qualified6.C | 10 ++++++++++ > 2 files changed, 11 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/parse/qualified6.C > > diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc > index 169e6a62f5f..2235da10c7c 100644 > --- a/gcc/cp/parser.cc > +++ b/gcc/cp/parser.cc > @@ -25933,6 +25933,7 @@ cp_parser_class_specifier_1 (cp_parser* parser) > case CPP_OPEN_PAREN: > case CPP_CLOSE_PAREN: > case CPP_COMMA: > + case CPP_SCOPE: > want_semicolon = false; > break; > > diff --git a/gcc/testsuite/g++.dg/parse/qualified6.C b/gcc/testsuite/g++.dg/parse/qualified6.C > new file mode 100644 > index 00000000000..68b51f771ec > --- /dev/null > +++ b/gcc/testsuite/g++.dg/parse/qualified6.C > @@ -0,0 +1,10 @@ > +// PR c++/90107 > +// { dg-do compile } > + > +struct A; > +namespace N { extern A a; } > +struct A {} ::N::a; > + > +struct A1; > +struct B { static A1 a1; }; > +struct A1 {} ::B::a1; > > base-commit: 58e4a744b6e8140499ed6c33a8e9a6557e102f74